Repository navigation
fix(vm): keep the guest root readable under a private umask - #5099
TaylorMutch merged 2 commits into
Conversation
Create guest dirs as 0755 and normalize the overlay root at boot. Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
@elezar @johntmyers could you please accept #4014 so the issue check can pass? PTAL, and |
|
Thanks for this. It matches the root cause we hit on RHEL 9 and Ubuntu 24.04 with the deb unit's |
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Thanks. Added a test that host state dirs stay 0700. |
|
/ok to test 62f30d9 |
|
Label |
Summary
A private gateway umask (the packaged
UMask=0077) made the guest/and/opt/openshellunreadable to the sandbox user.Related Issue
Closes #4014
Changes
/overlay/upperto root:root 0755 before the overlay mount.Release Notes
VM sandboxes now start when the gateway runs with a restrictive umask.
Testing
cargo fmt,cargo clippy -p openshell-driver-vm --all-targets -- -D warningsandcargo test -p openshell-driver-vmpass.VM e2e
vm_overlayunderumask 077, gateway uid 1000, sandbox uid 1001: on main both tests fail withread /proc/self/status: Permission denied. With this change both pass.Checklist