Repository navigation
feat(gateway): expose workspace service route snapshots and watches - #4941
Draft
TaylorMutch wants to merge 1 commit into
Draft
TaylorMutch wants to merge 1 commit into
TaylorMutch wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
9 tasks done
|
🌿 Preview your docs: https://nvidia-preview-pr-4941.docs.buildwithfern.com/openshell |
This was referenced Oct 27, 2026
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 03:15
c724036 to
932643d
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 05:42
932643d to
6c83b66
Compare
This was referenced Oct 27, 2026
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 06:24
6c83b66 to
755e4d1
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 06:25
755e4d1 to
0944ea2
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 06:46
0944ea2 to
8504067
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 27, 2026 21:06
8504067 to
feac6b4
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 28, 2026 17:05
feac6b4 to
0939a70
Compare
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 28, 2026 22:52
0939a70 to
cf5448a
Compare
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
TaylorMutch
force-pushed
the
feat/4667-service-discovery/TaylorMutch
branch
from
October 29, 2026 01:16
cf5448a to
d43f1ae
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose accepted supervisor installations through GetServiceRouteSnapshot and WatchServiceRoutes for one explicit authorized workspace. Independent proxies and infrastructure controllers consume exact hostnames and trusted supervisor endpoints through the same API.
Rebased onto main at
9f1cdb4ef. Stacked onfeat/4939-service-advertisements/TaylorMutch.Related Issue
Closes #4667. Part of RFC 0017.
Changes
ResolveSupervisorAppEndpointcompute RPC. External consumers use the public discovery RPCs; ordinaryGetSandboxobservations do not resolve routes.Release Notes
Discovery and Kubernetes request flow
Discovery returns an application
hostnameand a trusted supervisorendpoint(host and port), together with installation identity and expiry.
nameis thesandbox route's service name; an empty value identifies the unnamed/default
service. It is not a Kubernetes Service resource name.
The endpoint is the owning supervisor Pod IP and app-listener port. Consumers
preserve the application hostname as TLS SNI and HTTP Host/authority. Multiple
routes can share one supervisor endpoint; the hostname selects the sandbox
instance and service. The authoritative public application URL is separate and
can use a different public port.
flowchart TB subgraph Control["Control plane: build and publish discovery"] SUP["Supervisor<br/>Reports installed routes against a lease"] GW["OpenShell gateway<br/>Validates installation and ownership"] KD["Kubernetes compute driver<br/>ResolveSupervisorAppEndpoint"] KUBE["Kubernetes objects + supervisor ownership<br/>Find and validate owning supervisor Pod"] API["Discovery API<br/>hostname + Pod IP:8443 + expiry"] CONSUMER["Sandbox proxy or<br/>example Kubernetes HTTPRoute controller"] SUP -->|"Installed-route advertisement"| GW GW -->|"Resolve trusted endpoint"| KD KD --> KUBE KUBE -->|"Validated Pod IP and listener port"| KD KD --> GW GW --> API API -->|"Snapshot / watch"| CONSUMER end subgraph Data["Application data plane"] CLIENT["Client<br/>https://team--demo--web.apps.example.com"] EDGE["Configured proxy or Kubernetes Gateway<br/>Public listener, e.g. port 443"] LISTENER["Owning supervisor Pod<br/>10.42.1.27:8443<br/>TLS app listener"] DISPATCH["Select sandbox instance + named service<br/>using SNI / Host"] CONNECTOR["Selected instance's sandbox connector"] APP["Application inside sandbox<br/>127.0.0.1:8080"] CLIENT --> EDGE EDGE -->|"Connect to discovered endpoint<br/>preserve application SNI / Host"| LISTENER LISTENER --> DISPATCH DISPATCH --> CONNECTOR CONNECTOR --> APP end CONSUMER -.->|"Configure forwarding"| EDGEAddresses, domain names, and ports above are illustrative. Discovery describes
accepted installations, not application health or external ingress readiness.
The Kubernetes driver resolves trusted endpoints; a separate consumer configures
HTTPRoutes or proxy forwarding. Application traffic bypasses the OpenShell
gateway. The proxy and example controller are separate consumers, not part of
this PR's implementation.
Testing
fdce6ef26: 2,557 server tests passed (34 ignored), 279 supervisor tests, 310 Kubernetes driver tests, 8 proxy tests, full Go SDK CI, and 431 gateway + 6 workspace + 6 proxy Helm tests. All eight PR layers independently passed locked Rust compilation with test targets. Repository pre-commit passed withSETUPTOOLS_SCM_PRETEND_VERSION_FOR_OPENSHELL=0.0.0; plain invocation hits an existing main-branch setuptools-scm failure parsing tagsdk/go/v0.1.6. The final advance to main9f1cdb4efchanges onlytests/suites/features/Cargo.lockin each validated layer. Live HA qualification was not rerun for this rebase.Qualification limits
Live HA validation exercised supervisor process/Pod loss on a local k3d cluster. Whole-node failure, real network partitions, metric-driven HPA, sustained production load, and published release artifacts remain unqualified. Grant-file projection contributes to revocation propagation time. Main now includes #4842 for gateway-mediated hashed hostnames. Direct application-listener/discovery hostnames remain readable; extending hashed naming to that path and installation-status presentation (#4670) remain separate work.
The example Kubernetes HTTPRoute controller is a deferred compatibility POC outside this stack.
Checklist
PR dependency order: #4936 → #4940 → #4941 → #4956 → #4963 → #4964 → #4957 → #4958.