Skip to content

ci(release): list failed jobs in pre-release failure notices - #4719

Merged
matthewgrossman merged 2 commits into
mainfrom
ci/4718-prerelease-failure-notice/matthewgrossman
Oct 19, 2026
Merged

matthewgrossman merged 2 commits into
mainfrom
ci/4718-prerelease-failure-notice/matthewgrossman

Conversation

@matthewgrossman

@matthewgrossman matthewgrossman commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

List the failed jobs, with links, in the pre-release failure Slack notification, so triage doesn't have to search a 90-job run for the problem. Drew suggested this in the triage thread for v0.1.5-pre.5.

Related Issue

Closes #4718

Changes

  • After the existing message, add a "Failed jobs" list linking every failure or timed_out job in the current run attempt. The list comes from the Actions jobs API, so the job now has actions: read.
  • If the jobs lookup fails, send the message without the list, as before.
  • CI.md mentions the job links.

For v0.1.5-pre.5 (run 39250333833), the message would be:

:x: OpenShell prerelease v0.1.5-pre.5 failed (attempt 1). Published artifacts remain available. @openshell-triage

Failed jobs
• Qualify / Security Scan / Cargo Deny / Cargo Deny
• Qualify / Release Qualification
View failed release run

Testing

  • Extracted the step script and ran it locally, with curl replaced by jq, against the real jobs of run 39250333833 and with a failed jobs lookup.

  • actionlint and shellcheck pass on the changed step.

  • I couldn't send a real Slack message from a branch. The first failed pre-release after merge will confirm it.

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated (if applicable)

  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

…ilure notices

The pre-release failure notification said only that the run failed.
Name the failed stage (build, publication, or release qualification),
link the tag, and list each failing job of the run attempt with a link.
Skip the aggregate Release Qualification job unless it is the only
failure, and still send the message if the jobs lookup fails.

Closes #4718

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@github-actions

Copy link
Copy Markdown

Drop the stage headline and the aggregate-job filtering. Keep the
existing message and append a link to each failed job.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
@matthewgrossman matthewgrossman changed the title ci(release): name the failed stage and failing jobs in pre-release failure notices ci(release): list failed jobs in pre-release failure notices Oct 19, 2026

@purp purp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@matthewgrossman
matthewgrossman added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit c38e279 Oct 19, 2026
81 of 83 checks passed
@matthewgrossman
matthewgrossman deleted the ci/4718-prerelease-failure-notice/matthewgrossman branch October 19, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(release): list failed jobs in pre-release failure notifications

3 participants