Skip to content

ci(helm): retry chart pushes when GHCR briefly misses a new manifest #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewgrossman merged 1 commit into from
Oct 19, 2026
Merged

ci(helm): retry chart pushes when GHCR briefly misses a new manifest #4578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions .github/actions/release-helm-oci/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,24 @@ runs:
shell: bash
run: |
set -euo pipefail
# Helm pushes the manifest by digest, then fetches it back to tag it.
# GHCR can briefly return 404 for a manifest it just accepted, so
# retry. Re-pushing the same archive is idempotent.
push_chart() {
local attempt
for attempt in 1 2 3 4; do
if helm push "$1" oci://ghcr.io/nvidia/openshell; then
return 0
fi
if [ "${attempt}" -lt 4 ]; then
echo "::warning::helm push of $(basename "$1") failed (attempt ${attempt}); retrying in $((attempt * 10))s."
sleep $((attempt * 10))
fi
done
return 1
}
for archive in /tmp/helm-charts/*.tgz; do
helm push "${archive}" oci://ghcr.io/nvidia/openshell
push_chart "${archive}"
done

- name: Push SHA-pinned chart
Expand All @@ -107,6 +123,20 @@ runs:
shell: bash
run: |
set -euo pipefail
# See "Push Helm chart to GHCR OCI" for why pushes retry.
push_chart() {
local attempt
for attempt in 1 2 3 4; do
if helm push "$1" oci://ghcr.io/nvidia/openshell; then
return 0
fi
if [ "${attempt}" -lt 4 ]; then
echo "::warning::helm push of $(basename "$1") failed (attempt ${attempt}); retrying in $((attempt * 10))s."
sleep $((attempt * 10))
fi
done
return 1
}
mkdir -p /tmp/sha-pin
for source_dir in "${GATEWAY_CHART_DIR}" "${WORKSPACE_CHART_DIR}"; do
chart_name="$(basename "${source_dir}")"
Expand All @@ -117,5 +147,5 @@ runs:
helm package "${sha_chart_dir}" --destination /tmp/sha-pin
done
for archive in /tmp/sha-pin/*.tgz; do
helm push "${archive}" oci://ghcr.io/nvidia/openshell
push_chart "${archive}"
done
Loading