Skip to content

docs(cli): document sandbox create size limits - #4447

Merged
johntmyers merged 1 commit into
NVIDIA:mainfrom
ericcurtin:docs/4291-sandbox-create-limits/ericcurtin
Oct 14, 2026
Merged

johntmyers merged 1 commit into
NVIDIA:mainfrom
ericcurtin:docs/4291-sandbox-create-limits/ericcurtin

Conversation

@ericcurtin

@ericcurtin ericcurtin commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Document the sandbox create command argument and --env size limits in the docs and --help.

Related Issue

Closes #4291

Changes

  • Docs: command argument limits and --env limits, and sandbox upload for larger input.
  • --help: per-value and per-argument limits.

Testing

  • Checks appropriate to the affected code and behavior pass
  • Unit tests added/updated (if applicable)
  • E2E tests added/updated (if applicable)

Ran mise run docs:nav, mise run docs:build:strict, cargo fmt --check, and checked sandbox create --help output. Limits match grpc/validation.rs.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@johntmyers @elezar PTAL when you get a chance, and /ok to test c59a9e52c465384396ee49716383b7837aa45a9c if it looks good. Thank you!

@johntmyers

Copy link
Copy Markdown
Collaborator

/ok to test c59a9e5

@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

PR Review Status

Thanks @ericcurtin, I checked the limits and upload guidance you asked us to review against the server validation and existing sandbox workflow. The documentation and CLI-help changes address #4291; the independent review found no blocking findings.

I posted /ok to test for the current head. Branch Checks and Helm Lint have started, but Trivy Changes and the docs preview are still awaiting GitHub workflow approval.

Action required: a maintainer must approve Trivy Changes and Branch Docs Preview so validation can finish.

Blocking findings: None.
Carried findings: None.
Non-blocking suggestions: None.

Gator metadata
  • Validation: Focused docs and CLI-help fix for docs(cli): sandbox create has undocumented 32768-byte arg, 8192-byte env and no-newline limits; point large inputs at --upload #4291; no overlapping PR identified.
  • Docs: Existing Fern sandbox overview updated; no navigation changes needed.
  • Checks: DCO and vouch passed; current-head Branch Checks and Helm Lint running. Trivy Changes requires workflow approval. Sandbox policy denied workflow-approval REST writes.
  • E2E: Not required for documentation and help text describing unchanged runtime behavior; no test labels applied.
  • Head SHA: c59a9e52c465384396ee49716383b7837aa45a9c
  • Base SHA: cfe9850145c8c08dee7e8f49066e6515a27a5631
  • Merge base SHA: f01a664029888ac32b007acb7e1f8ff823ba85bc
  • Patch ID: 6e5acc82310fc7d1bf45760b10dd77d92cfceefd
  • Gator payload: 12
  • Review mode: initial
  • Previous reviewed SHA: none
  • Review budget exhausted: no
  • Maintainer decision required: no convergence decision; workflow approval required
  • Next state: gator:blocked
  • Blocked reason: workflow_approval_required

@johntmyers johntmyers added gator:blocked Gator is blocked by process or repository gates gator:approval-needed Gator completed review; maintainer approval needed and removed gator:blocked Gator is blocked by process or repository gates labels Oct 13, 2026
@johntmyers
johntmyers enabled auto-merge October 13, 2026 23:59
@johntmyers
johntmyers added this pull request to the merge queue Oct 13, 2026
Merged via the queue into NVIDIA:main with commit 39b13d1 Oct 14, 2026
81 of 82 checks passed
@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

Monitoring Complete

Monitoring is complete because PR #4447 has merged.

Final status: Gator found no blocking review findings, required CI gates passed, and maintainer approval was present. E2E was not required for these documentation and CLI-help changes.

I am removing the active gator:approval-needed label because there is nothing left for Gator to monitor on this PR.

Gator metadata
  • Head SHA: c59a9e52c465384396ee49716383b7837aa45a9c
  • Gator payload: 12

@johntmyers johntmyers removed the gator:approval-needed Gator completed review; maintainer approval needed label Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(cli): sandbox create has undocumented 32768-byte arg, 8192-byte env and no-newline limits; point large inputs at --upload

2 participants