Skip to content

fix(release): qualify prerelease tag pushes - #4335

Merged
SDAChess merged 1 commit into
mainfrom
fix/4334-qualify-prerelease-tags/SDAChess
Oct 13, 2026
Merged

SDAChess merged 1 commit into
mainfrom
fix/4334-qualify-prerelease-tags/SDAChess

Conversation

@SDAChess

@SDAChess SDAChess commented Oct 8, 2026

Copy link
Copy Markdown
Member

Summary

A manually pushed prerelease tag now starts Release Tag qualification, so maintainers can create candidates directly from the command line. Add a concise internal release skill: pick the latest qualified prerelease, review it with the maintainer, and tag that exact commit as stable; create and qualify a prerelease first when none exists.

Release Auto-Tag retains its explicit dispatch because its GITHUB_TOKEN pushes do not trigger another workflow.

Related Issue

Closes #4334

Changes

  • Remove the -pre.* exclusion from Release Tag's push trigger.
  • Add the internal release-openshell skill and register it in the contributor inventory.
  • Align CI.md with prerelease and stable tag push triggers.

Testing

  • Checks appropriate to the affected code and behavior pass: actionlint for Release Tag and Release Auto-Tag, Markdown lint for the skill and changed docs, skill validation, and git diff --check.
  • Skill inventory, unique names, and internal metadata checks pass for all 23 skills.
  • Local skill discovery from a disposable copy exposes only the four public skills; the new maintainer skill remains internal. Used the cached Skills CLI without installing dependencies.
  • Unit and E2E tests are not applicable to this trigger and contributor-guidance change. No release workflow was dispatched during validation.
  • The local commit hook was bypassed with maintainer approval after failing because mise was absent from PATH; the focused checks above ran separately.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs: not applicable.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

@SDAChess
SDAChess enabled auto-merge October 9, 2026 09:20
alangou
alangou previously approved these changes Oct 9, 2026
@SDAChess
SDAChess added this pull request to the merge queue Oct 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 9, 2026
Signed-off-by: Simon Scatton <sscatton@nvidia.com>
@SDAChess
SDAChess force-pushed the fix/4334-qualify-prerelease-tags/SDAChess branch from 8faa516 to 2a208bc Compare October 13, 2026 11:45
@copy-pr-bot

copy-pr-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@SDAChess

Copy link
Copy Markdown
Member Author

/ok-to-test 2a208bc

@SDAChess
SDAChess enabled auto-merge October 13, 2026 11:53
@SDAChess
SDAChess added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit a9a635a Oct 13, 2026
77 of 78 checks passed
@SDAChess
SDAChess deleted the fix/4334-qualify-prerelease-tags/SDAChess branch October 13, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(release): qualify manually pushed prerelease tags

2 participants