Repository navigation
test(conformance): run driver suites with cargo - #3866
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-3866.docs.buildwithfern.com/openshell |
9fee853 to
9994506
Compare
f4da56b to
d23f53a
Compare
|
Analysis by agent found some cleanup that's worth addressing: Once the CLI crate is removed, these openshell-conformance items have no remaining callers:
Without the registry's consumer, a scenario added to SCENARIOS does not run unless a matching test file is also added. |
d23f53a to
baa4d59
Compare
baa4d59 to
8ec0bfc
Compare
0615bcf to
1e34f20
Compare
1e34f20 to
e85a46c
Compare
|
Two comments still refer to the removed standalone runner:
Could you drop "standalone" from both, since conformance now runs as the Cargo test suite? |
76cf598 to
2cc51ca
Compare
2cc51ca to
702405c
Compare
|
Label |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
702405c to
3d591af
Compare
Summary
Run driver conformance through the portable Cargo test suites instead of building and distributing the standalone conformance CLI. Remove the obsolete CLI crate and its unused library APIs now that all supported paths use the library-backed test suites.
Rebased onto main
ca187123don 2026-10-12.Related Issue
Follow-up cleanup for #2792 and #3864.
Changes
tests/suites/conformancewith Cargo.crates/openshell-conformance-cliand its workspace lockfile entry.OPENSHELL_BINpaths before Cargo changes the test working directory.Testing
Rebase verification on 2026-10-12:
nix develop --command cargo test --locked --package openshell-conformancepasses: 18 tests.cargo test --locked --manifest-path tests/suites/conformance/Cargo.toml --package openshell-test-conformance-cli --no-run.Earlier verification, before this rebase:
mise run --jobs 1 pre-commitpassescargo test --locked --package openshell-conformancepasses (18 tests)cargo test --locked --manifest-path tests/suites/conformance/Cargo.toml --package openshell-test-conformance-cli --no-runpassesnix-instantiate --parse tests/artifacts.nixpassesChecklist