Skip to content

refactor(cli): remove local Dockerfile image builds - #3214

Merged
SDAChess merged 1 commit into
NVIDIA:mainfrom
eviehoward:refactor/3098-remove-local-dockerfile-builds/eviehoward
Sep 9, 2026
Merged

refactor(cli): remove local Dockerfile image builds#3214
SDAChess merged 1 commit into
NVIDIA:mainfrom
eviehoward:refactor/3098-remove-local-dockerfile-builds/eviehoward

Conversation

@eviehoward

@eviehoward eviehoward commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove local Dockerfile and local build-context support from openshell sandbox create --from. --from now selects an existing sandbox, community sandbox name, or image reference only; callers build and tag images with the container engine used by their gateway first. Users must now build and tag an image with the container engine used by their gateway, then pass that image reference to --from.

Related Issue

Closes #3098

Changes

  • Remove CLI-side Dockerfile detection and image building.
  • Remove the no-longer-needed bootstrap image-build implementation and dependencies.
  • Return a message with actionable guidance when --from receives an explicit local path.
  • Update custom-image E2Es to build test images explicitly through the active container engine.
  • Update documentation, examples, agent scripts, and troubleshooting guidance for the image-first workflow.
  • Make agent launcher query gateway driver, then build image in matching Docker or Podman store.
  • Reject CONTAINER_ENGINE mismatch and unsupported gateway drivers before build.
  • Update CLI and gator agent skills for explicit image builds and gateway-selected container engines.

Testing

  • mise run pre-commit passes
  • mise run e2e passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated - not applicable

@copy-pr-bot

copy-pr-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

2000krysztof
2000krysztof suggested changes Sep 8, 2026
View reviewed changes
Comment thread crates/openshell-cli/src/run.rs
Comment thread examples/bring-your-own-container/README.md Outdated
Comment thread e2e/rust/tests/custom_image.rs
Comment thread crates/openshell-cli/src/run.rs
Comment thread docs/sandboxes/manage-sandboxes.mdx Outdated
@eviehoward
eviehoward force-pushed the refactor/3098-remove-local-dockerfile-builds/eviehoward branch from fce3a04 to 7a81e5a Compare September 8, 2026 09:32
@eviehoward

eviehoward commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @2000krysztof, I have addressed the requested changes 🙂

@2000krysztof

2000krysztof commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

All my concerns were addressed LGTM. Nice work @eviehoward :)

@SDAChess SDAChess added test:e2e Requires end-to-end coverage test:e2e-gpu Requires GPU end-to-end coverage test:e2e-kubernetes Requires Kubernetes end-to-end coverage labels Sep 8, 2026
@SDAChess SDAChess added this to the OpenShell 0.1.0 milestone Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/3214 does not exist yet. A maintainer needs to comment /ok to test 7a81e5a20ee6b22a7e16ac61ecdcf5317c70e4b9 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Label test:e2e-gpu applied, but pull-request/3214 does not exist yet. A maintainer needs to comment /ok to test 7a81e5a20ee6b22a7e16ac61ecdcf5317c70e4b9 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Label test:e2e-kubernetes applied, but pull-request/3214 does not exist yet. A maintainer needs to comment /ok to test 7a81e5a20ee6b22a7e16ac61ecdcf5317c70e4b9 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@SDAChess SDAChess removed this from the OpenShell 0.1.0 milestone Sep 8, 2026
@SDAChess

SDAChess commented Sep 8, 2026

Copy link
Copy Markdown
Member

/ok-to-test 7a81e5a

SDAChess
SDAChess previously approved these changes Sep 8, 2026
View reviewed changes
@eviehoward
refactor(cli): remove local Dockerfile image builds
34ed80d 
Signed-off-by: Evie Howard <evhoward@redhat.com>
@eviehoward
eviehoward force-pushed the refactor/3098-remove-local-dockerfile-builds/eviehoward branch from 7a81e5a to 34ed80d Compare September 9, 2026 10:35
@SDAChess

SDAChess commented Sep 9, 2026

Copy link
Copy Markdown
Member

/ok-to-test 34ed80d

@SDAChess
SDAChess added this pull request to the merge queue Sep 9, 2026
Merged via the queue into NVIDIA:main with commit 6e6b3c8 Sep 9, 2026
78 checks passed
@johntmyers johntmyers mentioned this pull request Sep 17, 2026
Closed
2 of 10 tasks
This was referenced Sep 30, 2026
Closed
Merged
@rsliter rsliter mentioned this pull request Oct 9, 2026
Closed
zanetworker added a commit to zanetworker/OpenShell that referenced this pull request Oct 21, 2026
@zanetworker
docs(sandbox): align workload image requirements with current runtime
5a44469 
Workload images no longer need iproute2 or nftables since the supervisor
moved out of the workload (NVIDIA#2942). Docker and Podman run images without
USER as UID/GID 1000 (NVIDIA#3386), the driver creates /sandbox, and the CLI no
longer builds Dockerfiles (NVIDIA#3214). Update the bring-your-own-container
example and the runtimes page to match.

Fixes NVIDIA#3965

Signed-off-by: Adel Zaalouk <azaalouk@redhat.com>
syeedali pushed a commit to syeedali/OpenShell that referenced this pull request Oct 21, 2026
@zanetworker
docs(sandbox): align workload image requirements with current runtime (…
229382e 
…NVIDIA#3967)

Workload images no longer need iproute2 or nftables since the supervisor
moved out of the workload (NVIDIA#2942). Docker and Podman run images without
USER as UID/GID 1000 (NVIDIA#3386), the driver creates /sandbox, and the CLI no
longer builds Dockerfiles (NVIDIA#3214). Update the bring-your-own-container
example and the runtimes page to match.

Fixes NVIDIA#3965

Signed-off-by: Adel Zaalouk <azaalouk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SDAChess SDAChess SDAChess approved these changes
@mrunalp mrunalp Awaiting requested review from mrunalp
@sjenning sjenning Awaiting requested review from sjenning
@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr
+1 more reviewer
@2000krysztof 2000krysztof 2000krysztof approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test:e2e Requires end-to-end coverage test:e2e-gpu Requires GPU end-to-end coverage test:e2e-kubernetes Requires Kubernetes end-to-end coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor(cli): remove local Dockerfile builds from sandbox --from

3 participants

@eviehoward @2000krysztof @SDAChess