Repository navigation
fix: restart after correction context overflow - #1115
Draft
andreatnvidia wants to merge 1 commit into
Draft
andreatnvidia wants to merge 1 commit into
andreatnvidia wants to merge 1 commit into
Conversation
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A parser failure appends the invalid response and correction instructions to the conversation. If the next request exceeds the provider's context window,
generateandageneratecurrently exit even when conversation restarts remain. Restart from the latest checkpoint when only added history overflows, consuming the existing restart budget.Related Issue
N/A. The regression tests provide a synthetic reproduction without external services or datasets.
Changes
Testing
Synthetic MRE: return an invalid response, raise
ProviderError(CONTEXT_WINDOW_EXCEEDED)on its correction request, then return a valid response. With two correction steps and one restart, the expected request message counts are[1, 3, 1]. Before this fix, both sync and async stop at[1, 3]without using the restart.PYTHONPATHwith the existing development interpreter.make install-devrequires uv >=0.13.4; the available uv is 0.12.9.Checklist