Repository navigation
fix: move skill invocation guidance into descriptions - #1107
andreatnvidia wants to merge 10 commits into
Conversation
Move invocation guidance into descriptions for cross-harness discovery. Carry forward janEbert's contribution in #1006 from signed commit 963a714, retaining its DCO sign-off. Preserve current main's invocation controls and all skill bodies. Closes #1010 Co-Authored-By: janEbert <janpabloe@nvidia.com> Signed-off-by: janEbert <janpabloe@nvidia.com> Signed-off-by: Andre Manoel <amanoel@nvidia.com>
[Medium impact] The PR appears safe to merge. SummaryMoves invocation guidance into descriptions across seven skills while preserving their bodies and invocation controls.
Reviews (10) · Last reviewed commit: "Attach NVSkills validation signatures" · Reviewed by Greptile |
svcnvidia-nemo-ci
left a comment
There was a problem hiding this comment.
No merge-blocking defects found across the seven changed files. The descriptions match the existing argument contracts, including PR-number and branch review selection, the optional title update, and the dataset-description argument. Skill bodies and remaining invocation controls are preserved.
Validation was static only; no YAML parser, tests, or skill workflows were executed. Two delegated reports were unavailable despite completed statuses; their assigned files and directly affected contracts were independently inspected.
Note: formal approval is not available for this request, so this review is posted as a comment only.
Review generated by codex. This was a full review. Request a full review with /review reset=true.
|
/nvskills-ci |
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
/nvskills-ci |
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
/nvskills-ci |
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
/nvskills-ci |
Temporarily reduce setup to a no-op to isolate the preflight failure.\nRestore the complete fixture after collecting the diagnostic result. Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
/nvskills-ci |
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
/nvskills-ci |
Temporarily isolate downloading, verifying, and executing uv in the Astra sandbox. Restore the complete fixture after CI captures this diagnostic commit. Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
/nvskills-ci |
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
Signed-off-by: Andre Manoel <amanoel@nvidia.com>
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Summary
Invocation guidance in
argument-hintis missing from the standard skill metadata that other harnesses load. Move it into natural-language descriptions across the seven affected skills, following the Agent Skills specification.Carries forward @janEbert's original contribution in #1006, based on his signed commit 963a7145. The maintainer commit credits him as co-author, retains his existing DCO sign-off and adds my own.
Related Issue
Closes #1010
Changes
Move argument guidance into descriptions for
commit,create-pr,review-code,search-docs,search-github,update-pranddata-designer.Preserve quoted literals such as
"--title", all skill bodies and current main's invocation controls, including model invocation forreview-code.Keep the useful Claude Code extensions in place. Claude Code documents
argument-hintas an autocomplete hint; the descriptions now carry the guidance across harnesses.Add evaluation-only CLI installation and an offline model alias through
evals/config.yml, so the script-writing test has its prerequisites. The fixture uses a loopback endpoint and no inference credentials.Testing
"--title"and invocation controls.git diff --checkpassed. Validation used current main's existing environment because localuvis below the workspace's required version./tmpmountednoexec. The setup uses the image's Python/pip to create an isolated environment withoutensurepip; it completed in 31 seconds within Harbor's 120-second setup limit.f023dce0. NVSkills Tier 3 also passed: all four agent trials completed, and both Claude Code and Codex passed every evaluation dimension. The content gate passed. The sandbox image must provide a compatible Python, thevenvmodule and pip 22.3+. Local unit/E2E tests were not rerun for this skill metadata and evaluation setup change.Checklist
triaged