You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
isPast and rsvpId in lib/events.ts decide whether an event is over, and build RSVP document ids.
There are no tests for it yet.
Cover at least
an event whose endsAt is before now is past
with no endsAt, it falls back to startsAt
an event ending exactly at now is not past
pass now explicitly, never rely on the real clock
rsvpId is deterministic, and differs for different users or events
How
Create lib/events.test.ts next to the code. Follow the style of lib/github-auth.test.ts.
Run npm test. Then break the code on purpose (flip a condition) and watch at least one of your tests fail. Paste that failure output in the PR description, then undo the break.
Test behaviour through the exported function only. Don't change the source file unless you find a bug, and if you do, stop and comment on this issue first.
Size: ~30–60 lines of tests, 0 lines of source.
Taking this? Comment /assign and the bot assigns you if it's free. One issue per person at a time; comment /unassign to hand it back. That's milestone 2 of the 10 PR Journey. Setup, the checks CI runs, and how to open the PR from your fork are in CONTRIBUTING.md. Put Fixes #<this issue> in your PR description.
Activity
Tejasrastogi commentedon Sep 28, 2026
/assign
github-actions commentedon Sep 28, 2026
@Tejasrastogi it's yours! 🎉
main, withFixes #99in the description.Can't finish it? Comment
/unassignso someone else can pick it up.