Skip to content

Unit tests for signSession and verifySession #104

Open

Description

@geetxnshgoyal

What

signSession and verifySession in lib/auth.ts issue and check the portal's session tokens.

There are no tests for it yet.

Cover at least

  • sign then verify gives back the same claims
  • undefined, "" and garbage → null
  • a token with one character changed → null
  • a token signed with a different secret → null (set process.env.JWT_SECRET inside the test and restore it afterwards)
  • an expired token → null, using Vitest's fake timers (vi.useFakeTimers())

How

  • Create lib/auth.test.ts next to the code. Follow the style of lib/github-auth.test.ts.
  • Run npm test. Then break the code on purpose (flip a condition) and watch at least one of your tests fail. Paste that failure output in the PR description, then undo the break.
  • Test behaviour through the exported function only. Don't change the source file unless you find a bug, and if you do, stop and comment on this issue first.

Size: ~30–60 lines of tests, 0 lines of source.


Taking this? Comment /assign and the bot assigns you if it's free. One issue per person at a time; comment /unassign to hand it back. That's milestone 2 of the 10 PR Journey. Setup, the checks CI runs, and how to open the PR from your fork are in CONTRIBUTING.md. Put Fixes #<this issue> in your PR description.

Activity

  1. Anshsaxena07 commented on Sep 23, 2026

    @Anshsaxena07

    /assign

  2. github-actions commented on Sep 23, 2026

    @github-actions

    @Anshsaxena07 it's yours! 🎉

    1. Fork the repo and create a branch: see CONTRIBUTING.md.
    2. Open your PR from your fork into main, with Fixes #104 in the description.
    3. Make sure CI (Lint, Test, Type-check & build) is green.

    Can't finish it? Comment /unassign so someone else can pick it up.

  3. Anshsaxena07 commented on Sep 24, 2026

    @Anshsaxena07

    /unassign

  4. github-actions commented on Sep 24, 2026

    @github-actions

    @Anshsaxena07 you've been unassigned. This issue is open for someone else to pick up.

  5. prachidarshi-2307 commented on Sep 27, 2026

    @prachidarshi-2307

    /assign

  6. github-actions commented on Sep 27, 2026

    @github-actions

    @prachidarshi-2307 it's yours! 🎉

    1. Fork the repo and create a branch: see CONTRIBUTING.md.
    2. Open your PR from your fork into main, with Fixes #104 in the description.
    3. Make sure CI (Lint, Test, Type-check & build) is green.

    Can't finish it? Comment /unassign so someone else can pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions