Repository navigation
Conversation
Show exp3list (not exp2list) in the filelist example, close the quote in the filename_seq_list example, say that filename_seq_list holds files that each list the obs_seq filenames of one experiment, describe print_every as printing at multiples of print_every, and name quickbuild.sh in the Building section. Part of NCAR#808
Collaborator
|
Thanks for this pull request @barrosyan! Some of the team are out of the office over the next few weeks so it might be a little while before we get to this. |
hkershaw-brown
force-pushed
the
docs/808-obs-common-subset-fixes
branch
from
October 21, 2026 13:46
6e2eb8e to
01909a2
Compare
add program to list of serial programs if needed
hkershaw-brown
approved these changes
Oct 21, 2026
hkershaw-brown
left a comment
Collaborator
There was a problem hiding this comment.
Approved!
Thanks barrosyan, we'll bundle this with the next release of DART.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Documentation fixes for
obs_common_subset, taken from the list in #808. The reason: the examples in the page contain mistakes that a reader copying them would hit.cat exp2listafter creatingexp3list; it now showscat exp3list.filename_seq_listexample was missing the opening quote beforeexp3list.obs_seqfilenames.print_everyentry said the count is printed "every Nth set of obs"; it now says it is printed at multiples ofprint_every.$DART/models/*/workdirectories" build the tool; it now names thequickbuild.shscript (the script in those directories is calledquickbuild.sh, and the next paragraph already uses that name).Fixes issue
Fixes #808
moved rest of #808 to #1196
Part of #808. Not addressed here: the
obs_selectionlink item (the:ref:already resolves to theobs_selectionpage), and the discussion about the Fortran header comment and the error message for differing ensemble sizes, which change code and are better decided by the DART team.Types of changes
Documentation changes needed?
Tests
Checked the modified file with docutils (no warnings, the namelist table keeps its column widths). I did not build the full Sphinx site.
Checklist for merging
(I left the changelog and
conf.pyitems for the team, since the changelog is organized by release tag.)