Skip to content

bug: hardcoded var_ids to qtys in the Icepack model_mod #1194

Open

Description

@mjs2369

NOTE that this issue was created as practice in the CICE DAlooza software sesh. There are many issues with the Icepack model_mod which will be addressed in the larger refactor

Describe the bug

var_ids in the Icepack model_mod lon_lat_interpolate routine are hardcoded to specific positions in the seaice_quantiities_mod

if (qty == 14) then
var_id = 1
else if (qty == 15) then
var_id = 2
else if (qty == 16) then
var_id = 3
endif

  1. List the steps someone needs to take to reproduce the bug.
    Someone adds a new qty to the module, if it changes the order of the qtys, the code would break

  2. What was the expected outcome?
    qtys can be easily added to icepack without having to change the hardcoded values

  3. What actually happened?
    the var_ids are no longer correctly matched to the QTYs

Error Message

TBD, maybe none

Which model(s) are you working with?

Icepack

Version of DART

Which version of DART are you using?
v11.25.3

Have you modified the DART code?

No

Build information

Please describe:

  1. The machine you are running on (e.g. windows laptop, NSF NCAR supercomputer Derecho).
  2. The compiler you are using (e.g. gnu, intel).
    All machines, all compilers

Activity

  1. changed the title [-]bug: hardcoded vra_ids to qtys in the Icepack model_mod[/-] [+]bug: hardcoded var_ids to qtys in the Icepack model_mod[/+] on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions