Skip to content

bug: wrf convert_vertical_state does not use which_vert, #1038

Open

Description

@hkershaw-brown

Skeleton will fill in later

wrf convert_vertical_state

subroutine convert_vertical_state(state_handle, num, locs, loc_qtys, loc_indx, &

Does not use the passed in which_vert. It uses a module global
wrf%dom(id)%localization_coord

if (wrf%dom(id)%localization_coord == VERTISLEVEL) then

So if you call convert_vertical_state to test the routine, and pass in a which_vert, this is ignored and whatever is set in the model_nml is used.

Activity

  1. hkershaw-brown commented on Jan 9, 2026

    @hkershaw-brown
    CollaboratorAuthor

    Same bug in convert_vertical_obs

    ignores the input which_vert:

    DART/models/wrf/model_mod.f90

    Lines 3027 to 3044 in 4c89e64

    subroutine convert_vertical_obs(state_handle, num, locs, loc_qtys, loc_types, &
    which_vert, status)
    type(ensemble_type), intent(in) :: state_handle
    integer, intent(in) :: num
    type(location_type), intent(inout) :: locs(:)
    integer, intent(in) :: loc_qtys(:)
    integer, intent(in) :: loc_types(:)
    integer, intent(in) :: which_vert
    integer, intent(out) :: status(:)
    integer :: i
    do i=1, num
    call vert_convert(state_handle, locs(i), loc_qtys(i), status(i))
    enddo
    end subroutine convert_vertical_obs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingwrfWeather Research & Forecasting Model

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions