Repository navigation
bug: ROMS salinity unit mismatch dart observation converters wod, GTSPP are in MSU #1003
Description
🐛 Your bug may already be reported!
User reported, will reprduce
Describe the bug
- Use pmo with wod ocean observation sequences
- obs is in MSU
- salinity fwd op in PSU
Which model(s) are you working with?
ROMS_rutgers
Version of DART
Which version of DART are you using?
v11.19
Have you modified the DART code?
No
Build information
Please describe:
- The machine you are running on (e.g. windows laptop, NSF NCAR supercomputer Derecho).
- The compiler you are using (e.g. gnu, intel).
Activity
hkershaw-brown commentedon Nov 25, 2025
MITgcm uses PSU
fix: saliniy units to match observation converters in kg/kg
hkershaw-brown commentedon Nov 25, 2025
Discussion today at standup that there are converters that we do not have in DART (collaborators - I am not sure who) that output PSU (g/g). This is a pain, but so as to not break their code, namelist option for ROMS_rutgers & MITgcm to have model_interpolate give MSU or PSU for salinity.
Note if you do make a obs_def for insitu temp this unit issue will need to be taken care of. Currently the ocean model_mods are all doing their own insitu temp conversion inside model_interpolate
fix: ROMS option to have model_interpolate saliniy units in kg/kg (de…
fix: ROMS option to have model_interpolate saliniy units in kg/kg (de…
hkershaw-brown commentedon Nov 25, 2025
Punting on MITgcm ocean since it has a converter in the model directory: https://github.com/NCAR/DART/blob/main/models/MITgcm_ocean/create_ocean_obs.f90
and with observation converter in this model module: https://github.com/NCAR/DART/blob/main/models/MITgcm_ocean/dart_MITocean_mod.f90
seems to be hfradar. Will move this MITgcm units to another issue