Repository navigation
Conversation
dbeley
force-pushed
the
feat/add-opus-support
branch
from
May 2, 2026 21:57
f5bb767 to
c8ee26e
Compare
Owner
|
Thanks again for these, also looking at merging these. |
MrSimmo
added a commit
that referenced
this pull request
Oct 9, 2026
README gains a Contributors section (David BELEY: #1 and the features first built in #2; Anupam Mediratta: #5) and the 3.12 features. CHANGELOG-3.12.md credits both. docs/v3-12-report.md: what changed, the TV checklist, and the drafted PR #2 close comment, notes for #1 and #5, and release notes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013mv8TsDEFMZoEPWbSeTG3r
Owner
|
Thank you, @dbeley — every feature in this PR is in Sonance 3.12. The PR was written against the code from before 3.9, and the interface has moved on a lot since (rem sizing, a new focus style, Tizen 5.0's CSS limits), so I couldn't merge it as it stands. Inuilt on 3.11 using your commits as the guide: 44b2771 (Opus, random albums, Homerows), 0067637 (the Albums sort) and c8ee26e (popular songs). Every 3.12 commit that carries one of them credits you as co-author, and you're in the README's Contributors and the 3.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some features I found were missing:
I successfully tested all those elements on my TV in the last few days 👍
Also regarding the PR in itself, I haven't included the following updated files:
Sonance3.wgtjs/sonance-core.min.jsjs/sonance-screens.min.jsI don't think those files should be kept in the repo, they should only be generated when a new release is made.