Repository navigation
Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
12 of 18 tasks
Qubitium
marked this pull request as ready for review
November 3, 2026 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement an experimental native BGR execution adapter: general Brain/Grunt/Reviewer messaging, isolated reviewer execution over frozen Git snapshots, and trusted cross-process source recording. Omnigent remains the sole scheduler and durable control plane. Companion: ModelCloud/omnigent#98.
bgr/capabilities/readand identity/epoch-fenced bind, send, deliver, inspect, checkpoint and cancel RPCs. Requireinitialize.capabilities.experimentalApi=true.task,question,answer,progress,status_query,status_reply,resultandcancelthrough the existing deferred mailbox boundary andbgr_send_message/bgr_reply_message/bgr_report_status. Exact retries deduplicate; changed bodies, stale identities, cancelled assignments and malformed/oversized envelopes fail. Delivery acceptance is not model consumption.bgr/message/record {threadId,identity,envelope}so the source process records host-authored task metadata before another process returns correlated callbacks. This makes no provider request and adds no second scheduler/mailbox.bgr/reviewer/startwith a fresh isolated thread/home, exact immutable Git base/head, bounded changed-file blobs and diff, one Brain peer, and exactly four tools: status/send/reply/read-review-snapshot. No shell, MCP, ambient instructions, skills, memory, or unsafe settings overrides. Ordinary reviewer bind remains forbidden.Current native capabilities include all three roles, general messaging/callbacks, task dispatch,
hostDelivery,hostRecord,reviewerStart,reviewerSandboxand scoped status requests with explicit evidence limits. Native mailboxes/bindings remain process-local:durableMailbox,restartRecovery,consumptionReceiptsandcrossHostDeliveryare false. Checkpoint flush does not constitute durable BGR recovery; cancellation does not attest external-process termination.See the implemented contract. The unchanged
7b588af32candidate now passes a real Omnigent browser/native no-findings campaign through publication previews and explicit known-child shutdown. This does not establish consumption receipts, process-loss recovery, autonomous review quality or external publication. Nothing merged or released.Post-review regressions
[false, true, true]; no BGR reply escaped the canceled runtime. After the fix: one request, query absent, original turn interrupted, no second turn or reply during the bounded observation. Idle cancel is idempotent, rejects new delivery, and makes zero model requests. Queue-level coverage preserves unrelated mail/user input; admission coverage cancels during startup and interrupts reservations both before startup and during lifecycle admission.Test Plan
Integrated Omnigent campaign — unchanged
7b588af32, Omnigente1fb76c04Real browser, server, ordinary host, app-server and MultiDex TUI; only provider responses are scripted. One browser-created BGR session delivers its actual initial task exactly once, with no resend/synthetic boot/manual tool injection.
/status, metadata, durable binding and provider cache key. Independent Brain/Grunt/Reviewer models and high/low/medium/high reasoning settings preserved.mcp__omnigent/sys_bgr_control, all native BGR tools, 12 control calls and 45 SSE done items preserve separate namespace/name/string arguments/call IDs.publish:false, no external publication writes. Consumption receipts false, not inferred from replies or stop ACKs. No escaped-descendant/process-loss containment claim. Failed-stop, close/retry and second-round cases remain lower-layer tests, not browser evidence.The auxiliary continuous SQL sampler failed on byte serialization, and no separate native-close completion timestamp was captured. Stop evidence instead correlates actual retained subprocess return codes at host ACK, process absence, genuine completed outputs and final durable records.
The companion Omnigent PR retains its unresolved database-policy merge gate. This native candidate was not rebuilt or modified for the acceptance run.
Current simulated-provider validation —
066039f948aa9d11a69d1bc2ab7c738d78e466afNative app-server tests use a local simulated Responses endpoint; the real runtime and tool dispatch execute.
From
codex-rs, using the documented bounded cached build settings:Earlier status-bridge regression runs (historical, not current capability inventory)
Commands run from
codex-rswith the documented bounded cached Rust build settings:cargo test -p codex-core --lib bgrcargo test -p codex-app-server --test all bgrRUST_MIN_STACK=8388608 cargo test -p codex-core --lib mailboxRUST_MIN_STACK=8388608 cargo test -p codex-core --lib interruptcargo test -p codex-core --lib abort_empty_active_turn_preserves_pending_inputcargo test -p codex-app-server --test all turn_interruptcargo test -p codex-protocol --lib bgr::testscargo test -p codex-app-server-protocol --libcargo check -p codex-app-server -p codex-tuicargo clippy -p codex-protocol -p codex-app-server-protocol --lib -- -D warningscore/src/compact_remote_v2.rs:531(expect_used) andcore/src/thread_manager.rs:981(redundant_clone); no new BGR diagnosticscargo fmt --all --check, targeted Prettier andgit diff --checkNative regressions cover query anchor A versus observed head B, and null query anchor versus observed non-null head, through both same-process and trusted-host delivery. Both new anchor cases failed against the original implementation before the fix. The external-brain runs verify that the sole loaded native thread is the worker, accept/deduplicate while its work tool is held open, reject spoofed sender/team/epoch/role, malformed sender/session, stale target attempt and unsupported scope/kind, then emit a correlated reply and continue the same turn after the safe boundary. All logical IDs use host-like lower32hex values; SHA anchors are 40hex. The disabled-experimental test also rejects host delivery.
Schema regeneration in the initial slice also normalizes existing
setAgentSettings/reasoning-default fixture drift without changing those runtime types. Tests extend existing native app-server mock-Responses/dynamic-tool fixtures; no live-provider credentials or UI setup required. A real native wire capture (capability/report-tool schema, host-delivery request/receipt and reply notification) is supplied separately for controller conformance. No merge or release packages.The wider core mailbox/interrupt groups use an explicit 8 MiB test-thread stack: default-stack runs overflowed in the existing
multi_agent_v2_wait_agent_*test functions. These groups pass withRUST_MIN_STACK=8388608. Focused BGR and native app-server tests use the default stack.Earlier ordinary host UI/TUI regression (not full BGR acceptance)
Post-review validation used Omnigent 9281c1118 and MultiDex 4db4f1608. The candidate package reported
codex-cli 0.166.0+4db4f1608; SHA-256aa9d1a932a68e636f5d429902755d048ead571f4461ed7f5e53067d2336a222e. The server, connected host, transport, bridge and MultiDex TUI were real; only model responses were scripted.Chromium 148.0.7778.96 with a fresh profile and GPU/WebGL disabled completed the flow. The original Chrome tab crashed with SIGSEGV on Terminal view; cause remains unresolved and is not attributed to this PR. These ordinary native interactions are regression evidence, not BGR typed-mail cancellation, live-provider, cross-provider or full BGR acceptance.
Manual recheck: use the candidate native package with the connected Omnigent host, send a Chat prompt, open Terminal and send a TUI prompt, interrupt an active turn with Escape, send a follow-up, then reload Chat. Verify completed replies appear once and the canceled turn never later produces a response.
Link to Devin session: https://app.devin.ai/sessions/e683ca3709c24c0e817bec37549367cf
Open in Devin Desktop: https://app.devin.ai/desktop/session/e683ca3709c24c0e817bec37549367cf?variant=devin
Requested by: @Qubitium