Skip to content

groupType expansion needs full testing with devices. #306

Open

Description

@adcxyz

ATM groupTypes like noteOnOff, noteOnOffTouch expand properly into MKtlElements,
but not yet into proper responders and midi lookup dict entries within MIDI devices.
-> Do extensive tests of all types and their expansion.

Activity

  1. adcxyz commented on Jul 7, 2017

    @adcxyz
    ContributorAuthor

    expansion works now with 97e01f3, gui style does not propagate down correctly yet.
    still needs full test suite.

  2. LFSaw commented on Jul 12, 2017

    @LFSaw
    Member

    GUI looks like a new issue to me, no?

  3. adcxyz commented on Jul 13, 2017

    @adcxyz
    ContributorAuthor

    yes, could also be a new issue - the problem is more general / conceptual,
    namely what the clearest form of description is and how to write passing things
    down into the elements so they work correctly. My current idea is loosely:

    // element desc of an auto-expanding group:
    (
        // things that describe the group, such as name:
        key: \dings, 
    // this determines which set of what elements are made:
        groupType: \noteOnOffCtl, 
    // this expands into list that goes into  elements one by one:
        midiNum: [24, 24, 48], 
        // everything the elements share
        shared: (
            style: (row: 0, column: 1), 
        ), 
        // maybe allow adding extra elements that go into the group
        // not really sure this is a good idea 
        elements: [ 
             (elementType: \led, ioType: \out), 
        ]
    )
    )
    

    This should also include elements that have separate midiNums for output
    (e.g. setting moving faders or led indicators), not sure how best to do that.

    opinions please :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions