This repository was archived by the owner on Dec 30, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Dec 30, 2022. It is now read-only.
[BUG] Mods flagged outdated while they're actually up to date #52
Description
Describe the bug
Whenever I manually update a mod that's available on modrinth and curseforge (downloaded the mod from curseforge because it's not updated on modrinth yet), the modmanager flags the mod as outdated.
In addition, for Mousewheelie the modmanager downloads an outdated version (even though it's up to date on modrinth)
To Reproduce
Steps to reproduce the behavior:
- Install the latest mousewheelie mod (currently version
mousewheelie-1.7.3-newconfig.3+mc1.17.1-pre1 - Install the mod
- Launch Minecraft and the mod manager
- Mod is flagged outdated
- Update the mod through the mod manager and see that it downloads version
mousewheelie-1.7.3+mc1.17.1-pre1
Expected behavior
The mod manager should know that it's up to date
Screenshots
Please complete the following information:
- OS: Arch Linux
- Minecraft version: 1.17.1
- Version 1.0.2-alpha
Logs
Latest log: https://pastebin.com/T9rLHVTi
(it also contains an error where it can't find a jar for LibZoomer, I think that's part of the OkZoomer mod)
Activity
[-][BUG] Mods flagged outdated while they're actually newer[/-][+][BUG] Mods flagged outdated while they're actually up to date[/+]DeathsGun commentedon Sep 12, 2021
The log isn't available anymore on pastebin. Can you upload it here directly via drag n drop?
FPSUsername commentedon Sep 12, 2021
2021-09-12-2.log
DeathsGun commentedon Sep 13, 2021
Looks like mousewheelie isn't following the SemVer versioning scheme which fabric has implemented here.
I could fix it so that when two versions are the same the release date is compared and the newer gets selected
FPSUsername commentedon Sep 13, 2021
Oh okay, that makes sense, it's what I was thinking of as well. Not every plugin/mod follows the version scheme of spigot/fabric, especially with beta/alpha releases.
The solution you mention seems good to me (of course it needs to be checked for the MC version, but I bet that's already happening).
DeathsGun commentedon Sep 13, 2021
Yeah it filters automatically for the fabric loader and the correct mc version
DeathsGun commentedon Sep 27, 2021
Can you test the fix?
modmanager-1.1.0+1.17-alpha.jar.zip
FPSUsername commentedon Sep 28, 2021
Tried it, but unfortunately, mousewheelie isn't showing up anymore as outdated.
However, I found new issues:
Lithium's latest release is 0.7.4:
Heads down display is version 0.1.1, which I also have installed, yet the mod manager thinks it's version 0.0.0.
Dynamic FPS has a different version number on modrinth compared to what's in the jar file.
Last but not least, a miscellaneious:
I use a fork of the Iris shader which also has its own version of sodium. Sodium is build in into the new Iris shader, but not yet on the forked version.
Using the official Iris release (Modrinth):
K0-RR commentedon Sep 28, 2021
This issue is caused by the Heads down display itself - https://github.com/auoeke/heads-down-display/blob/1.17/src/main/resources/fabric.mod.json
DeathsGun commentedon Sep 28, 2021
I would suggest the following:
DeathsGun commentedon Sep 29, 2021
This version improves it a bit, but for mods who are declaring different version id's on modrinth and in their metadata is something I can't fix. You could only ask them nicely if they would follow the SemVer spec and only use the name field for differentiating between forge and fabric versions.
modmanager-1.1.0+1.17-alpha.jar.zip
DeathsGun commentedon Oct 1, 2021
If the anymore issues with versions not following SemVer then please consider asking the mod author to change their versioning
Use checksums when using SemVer fallback