Skip to content

Read services return soft-deleted rows #55

Open

Description

@brinehart

Files: core/csharp/MicroZen.Api/Services/OrganizationsService.cs:19-37, ClientsGrpcService.cs (reads)

What this is: GetOrganization, GetOrganizations, GetClient, GetManyClients.

Problem: None filter on DeletedOn == null. A disabled organization or deleted client is still returned by reads, so soft-delete has no effect on what callers see.

Fix: Add a DeletedOn == null condition, ideally as an EF Core global query filter on BaseEntity so every read is consistent.

If we skip it: "Deleted" records keep showing up.

Activity

  1. added
    Should FixRisky code without a test, real slowness, duplication, or code that should not exist
    on Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Should FixRisky code without a test, real slowness, duplication, or code that should not exist

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions