feature: Reveal text in operator-pending mode, and when jumping with flash.nvim (or similar plugins) #43

Activity

1. oblitzitate

   added

   enhancementNew feature or requestNew feature or request

   on Jun 27, 2024
2. MeanderingProgrammer

   closed this as completedin 467ad24on Jun 27, 2024
3. MeanderingProgrammer commented on Jun 27, 2024

   

   MeanderingProgrammer

   on Jun 27, 2024

   Owner

   More actions

   Hi, thanks for the feedback! I agree not rendering during operator pending mode makes a lot of sense.

   Have pushed a change: 467ad24, lmk if it works as expected.

   Disabling concealing is also possible if you want to do that for any reason in the future:

   require('render-markdown').setup({
       win_options = {
           conceallevel = { default = 0, rendered = 0 },
       },
   })

   As far as interacting with the various navigation helper plugins, I personally don't use them and don't particularly want to try out all the options so will let users bring up any poor behaviors and go from there.

   Thanks again!
4. oblitzitate commented on Jun 27, 2024

   

   oblitzitate

   on Jun 27, 2024

   Author

   More actions

   Still not working for me. No changes when I enter an operator (e.g. d) as the initial keystroke.

   My current config:

      {1 "MeanderingProgrammer/markdown.nvim"
       :name "render-markdown"
       :dependencies ["nvim-treesitter/nvim-treesitter"
                      "nvim-tree/nvim-web-devicons"]
       :opts
        {:headings [ "󰼏 " "󰎨 " "󰼑 " "󰎲 " "󰼓 " "󰎴 "]}}
   
5. MeanderingProgrammer commented on Jun 27, 2024

   

   MeanderingProgrammer

   on Jun 27, 2024

   Owner

   More actions

   I gotta ask, did you update the plugin?
6. oblitzitate commented on Jun 27, 2024

   

   oblitzitate

   on Jun 27, 2024

   Last edited by oblitzitate

   Author

   More actions

   Yes. Lazy shows the markdown.nvim commit to be 467ad24.

   I found out the issue occurs when I run require("which-key").register(). If I comment that out, it works, but I would rather not since which-key is integral to my workflow (and many other users).

   Not sure if it's a timing issue, or interruption issue, or a which-key bug, or what, but you may need to investigate that since a lot of users use which-key as a foundation for their config.

   Edit: Both markdown.nvim's reveal (if it worked) and which-key's popup would occur roughly at the same time so I'm assume the bug stems from there. My guess is that it accidentally grabs the mode of the which-key popup instead of the main buffer? Or maybe it applies the reveal on the which-key popup instead of the main buffer?
7. MeanderingProgrammer commented on Jun 27, 2024

   

   MeanderingProgrammer

   on Jun 27, 2024

   Owner

   More actions

   Ah I also use which-key, but have most of the presets disabled. In this case the operators preset is what causes the behavior.

   I'm seeing that with operators enabled which-key prevents the mode change from happening at all. As in it forces the editor to stay in normal mode. Which kind of makes sense, but that means with which-key the operator pending state doesn't exist.

   I don't think there's really anything to do. I can't infer an event that's not being triggered, will make a note of this somewhere though.

   Found an issue on which-key's side, it's expected behavior: folke/which-key.nvim#534.
8. khangnm1340 commented on Mar 21, 2025

   

   khangnm1340

   on Mar 21, 2025

   More actions

   buf_toggle() happens after flash.nvim even when placed first .
   I have this key map

   local flash = require("flash")
   vim.keymap.set("n", "s", function()
     require("render-markdown").buf_toggle()
     flash.jump()
     require("render-markdown").buf_toggle()
   end, { desc = "Flash (Conceal Off)" })
   

   even though render-markdown is place first, flash.nvim still grey out the screen without the unconcealment. Only when i press the first key does it unconceal. But when I tried replacing require("render-markdown").buf_toggle() with another command, that command executes first like normal.

   output.mp4