Skip to content

compute: drop constant errors at or beyond the dataflow until - #40539

Merged
antiguru merged 1 commit into
MaterializeInc:mainfrom
antiguru:moritz/cpu-329-refresh-constant-error-until
Nov 6, 2026
Merged

antiguru merged 1 commit into
MaterializeInc:mainfrom
antiguru:moritz/cpu-329-refresh-constant-error-until

Conversation

@antiguru

@antiguru antiguru commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Rendering a constant drops rows at or beyond the dataflow until, but emitted its error at the as-of regardless. On restart, a pending replacement for a REFRESH materialized view can get an as-of past its last refresh, so the error reached apply_refresh after the last refresh and tripped its soft assertion, crash-looping the replica. The error now follows the same until filter as the rows.

Adds the test-refresh-mv-constant-error-past-last-refresh workflow to test/cluster, which reproduces the panic on main and passes with the fix.

Closes: CPU-329

🤖 Generated with Claude Code

Rendering a constant drops rows at or beyond the dataflow `until` but
emitted its error at the as-of regardless. A pending replacement for a
REFRESH materialized view can get an as-of past its last refresh on
restart, so the error reached `apply_refresh` after the last refresh and
tripped its soft assertion, crash-looping the replica.

Closes: CPU-329

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@antiguru
antiguru marked this pull request as ready for review November 6, 2026 16:44
@antiguru
antiguru requested a review from a team as a code owner November 6, 2026 16:44
@antiguru
antiguru requested a review from DAlperin November 6, 2026 16:44

@DAlperin DAlperin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@antiguru
antiguru merged commit 73bf827 into MaterializeInc:main Nov 6, 2026
85 checks passed
@antiguru
antiguru deleted the moritz/cpu-329-refresh-constant-error-until branch November 6, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants