Repository navigation
Conversation
jubrad
force-pushed
the
justin/replica-sizes-disabled-column
branch
from
October 28, 2026 23:20
b643bdf to
179d1f8
Compare
jubrad
force-pushed
the
justin/replica-sizes-disabled-column
branch
from
October 29, 2026 19:52
179d1f8 to
d175434
Compare
Replicas keep running on disabled sizes, so anything joining replicas to sizes needs their rows. Add a disabled column instead of omitting them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jubrad
force-pushed
the
justin/replica-sizes-disabled-column
branch
from
October 31, 2026 04:26
d175434 to
ede4ed6
Compare
aljoscha
approved these changes
Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mz_catalog.mz_cluster_replica_sizesleaves out disabled sizes, but replicas keep running on them. Anything that joins replicas to sizes loses those replicas: the Console's replica list says "This cluster has no replicas", andmz_cluster_replica_utilizationandmz_cluster_replica_historydrop rows or report NULL credits. #39557 will disable sizes that were removed from the flag but are still in use, making this routine, so this should land first.Solution
mz_cluster_replica_sizeslists every size and gains adisabledcolumn.NOT disabled, gated on environment version so it keeps working against environments without the column.Testing
test/clustertest-sql-cluster-disknow expects a disabled size to be listed withdisabled = true.test/restartdisabled-cluster-replica-size-survives-restartnow checks that a replica on a disabled size still joins to its size row, withdisabled = true.Gotchas for reviewers
mz_catalogtable returns: anything that lists sizes to pick from now needsWHERE NOT disabled. Worth a release note.DISABLED_REPLICA_SIZES_MIN_VERSIONin the Console is26.50.0-devand has to match the release this lands in. Bump it before merging if it lands later.mz_%sizes.mz-clusterctl(environment.py), whoseDISTINCT ON (processes, workers) ... ORDER BY credits_per_hourcould now pick a disabled size.🤖 Generated with Claude Code