Repository navigation
AGENTS.md: leave feature-flag defaults to humans - #39718
Merged
Merged
Conversation
ggevay
force-pushed
the
gabor/agents-md-flag-defaults
branch
from
October 10, 2026 18:00
aa9a0a6 to
790d2a7
Compare
ggevay
changed the title
ggevay
force-pushed
the
gabor/agents-md-flag-defaults
branch
2 times, most recently
from
October 10, 2026 18:32
2a32088 to
20236d4
Compare
The feature-flag bullet told agents that every new flag defaults off in production and on in tests, and agent-written reviews raise deviations as blockers. The right production default depends on product context an agent rarely has, so agents now ask a human when adding a flag and do not question the chosen default in reviews. Tests should still usually run with the flag on. The bullet now points at the mzcompose parameter lists that CI and bin/sqllogictest read, instead of the --system-parameter-default flag those lists are passed through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ggevay
force-pushed
the
gabor/agents-md-flag-defaults
branch
from
October 10, 2026 18:34
20236d4 to
7fc87ae
Compare
ggevay
marked this pull request as ready for review
October 10, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AGENTS.md told agents that every new feature flag defaults off in production and on in tests, and agent-written reviews now raise deviations as blockers (#38845). The right default depends on product context: big new syntax may need to stay off so users don't rely on it before the syntax is settled, while a small, low-risk flag can ship on as an escape hatch. An agent rarely has that context.
Description
get_variable_system_parametersorget_minimal_system_parametersinmisc/python/materialize/mzcompose/__init__.py, whichbin/sqllogictestand mzcompose'sMaterializedservice pass to environmentd. It used to point at--system-parameter-default, the flag those lists are delivered through.TestHarness::with_system_parameter_defaultstays for Rust integration tests.🤖 Generated with Claude Code