Repository navigation
Make addresses a class instead of a list ($50) #137
Description
We should make a address class, that should have the methods that currently are in ejtp.address.
If it is a desired functionality, the address class could still implement the __getitem__ method so that code that assumes the address is a list will still work.
I see following advantages with doing that:
- for converting and creating addresses you will just use methods instead of (in my opinion) ugly auxiliary methods
- addresses themselves will be more descriptive, so a programmer will better understand how the address works while reading the source code
Activity
MaddieM4 commentedon Jun 8, 2013
I'm inclined to agree. This seems like a perfect fit for named tuples, if
it's supported in all our Python versions. If not, we can just go manual.
We also have to consider serialization - I'll check later if JSON can
nicely serialize arbitrary objects that provide the iteration interface.
On Sat, Jun 8, 2013 at 8:47 AM, Moritz Sichert notifications@github.comwrote:
MaddieM4 commentedon Jun 8, 2013
Looks like the JSON module is compatible with namedtuples, but not arbitrary iterables. And namedtuples can be subclassed if we want anything special. All of which is supported in Python 2.6+. So this is definitely the way forward, IMHO.
http://docs.python.org/dev/library/collections.html#collections.namedtuple
MaddieM4 commentedon Jun 8, 2013
Bounty is $50.
http://www.freedomsponsors.org/core/issue/275/make-addresses-a-class-instead-of-a-list
(Copied from acceptance criteria)
Create a namedtuple subclass for EJTP addresses, overriding the init function such that passing in a single string as an argument will automatically JSON decode the string and use that for initialization arguments. Then replace every usage of list addresses with the new Address class, wherever the replacement isn't totally insane. If you're not sure, ask in a Github comment, discussion is fun.
Implement Address class in ejtp/address.py