Skip to content

session_cnt not checked an stored #80

Open
Open
session_cnt not checked an stored#80

Description

@MpmTwtg
MpmTwtg
opened on Aug 12, 2024

SWL2001/lbm_lib/smtc_modem_core/lorawan_packages/fragmented_data_block_transport/v2.0.0/lorawan_fragmentation_package_v2.0.0.c

Lines 607 to 608 in d05dad5

// smtc_modem_hal_context_restore( CONTEXT_FUOTA, 0, (uint8_t
// *)(&(frag_session_data_tmp.frag_group_data.session_cnt_prev)), 2); // restore session_counter

SWL2001/lbm_lib/smtc_modem_core/lorawan_packages/fragmented_data_block_transport/v2.0.0/lorawan_fragmentation_package_v2.0.0.c

Lines 819 to 820 in d05dad5

// smtc_modem_hal_context_store( CONTEXT_FUOTA, 0, (uint8_t
// *)(&(frag_session_data_tmp.frag_group_data.session_cnt_prev)), 2 );

The session cnt is not used at all nor stored, according to ts004-2-0-0-fragmented-data-block-transport 3.3, L366-L388.

Also it would be nice to have a callback for the FRAGMENTATION_SESSION_SETUP_REQ,, we could use this to prepare the storage,
and then this could also have a reason for frag_session_data_tmp.frag_group_data.descriptor.

with kind regards,
MPM

Activity

  1. opeyrard commented on Aug 19, 2024

    @opeyrard
    opeyrard
    on Aug 19, 2024

    Hi,
    We are investigating and will update you.
    Many thanks,
    Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions