Repository navigation
Leave the Report a Problem options to support plugins - #2594
Merged
Merged
Conversation
Support had Report Issue, Submit Bug Report (added by LoopSupport) and Export Critical Event Logs side by side, with local export hidden at the bottom of the developer report form. People couldn't tell which to use. Support now has one Report a Problem row. It opens a screen listing the four options, each saying who gets the report: the developers privately, someone helping you, GitHub publicly, or critical event logs on request. Sharing a diagnostic report now generates it in place and opens the share sheet, instead of closing Settings and showing the old text view. The canceled automatic bolus alert opens the same screen.
Support now shows only what support plugins add, plus the build info. The report screen, developer report form and submitter move to LoopSupport, since Tidepool Loop will offer different options. Loop provides the critical event log export through the support delegate, and generateIssueReport now returns the full diagnostic report rather than only the device section. The canceled automatic bolus alert opens the first support plugin's Report a Problem screen, or shares a diagnostic report directly if none provides one.
ps2
changed the title
Contributor
|
Put the test in the wrong place. See LoopKit/LoopWorkspace#542 (comment) |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support had Report Issue, Submit Bug Report (added by LoopSupport) and Export Critical Event Logs next to each other, and local export was a button at the bottom of the developer report form. It wasn't clear which one to use.
The ways to report a problem now belong to support plugins, since Tidepool Loop will offer different options. DIY Loop's four options live in LoopSupport (LoopKit/LoopSupport#39), behind a single Report a Problem row.
In Loop:
SupportUIDelegate.criticalEventLogExportView()(Let support plugins provide Report a Problem and critical event logs LoopKit#660).generateIssueReport()now returns the full diagnostic report rather than only the device section.reportProblemView(). If no plugin provides one, it shares a diagnostic report directly.Merge LoopKit/LoopKit#660 first, then this and LoopKit/LoopSupport#39 together.
Testing:
LoopWorkspacebuild: all four options, critical event log export, and a 10 KB shared report.