Skip to content

Make the muted loop-not-running test wait for the reschedule #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ps2 wants to merge 1 commit into
base: dev
Choose a base branch
from
+24 −9
Open

Make the muted loop-not-running test wait for the reschedule #2592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions LoopTests/Managers/Alerts/AlertManagerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,21 +490,23 @@ class AlertManagerTests: XCTestCase {
UNUserNotificationCenter.current().removeAllPendingNotificationRequests()

let lastLoopDate = Date()
// Rescheduling reads the last loop date from the shared extension context
var context = ExtensionDataManager.context ?? StatusExtensionContext()
context.lastLoopCompleted = lastLoopDate
ExtensionDataManager.context = context

alertManager.loopDidComplete(lastLoopDate)
alertManager.alertMuter.configuration.startTime = Date()
alertManager.alertMuter.configuration.duration = .hours(4)
waitOnMain()

let testExpectation = expectation(description: #function)
var loopNotRunningRequests: [UNNotificationRequest] = []
UNUserNotificationCenter.current().getPendingNotificationRequests() { notificationRequests in
loopNotRunningRequests = notificationRequests.filter({
$0.content.categoryIdentifier == LoopNotificationCategory.loopNotRunning.rawValue
})
testExpectation.fulfill()

var loopNotRunningRequests = pendingLoopNotRunningRequests()
let deadline = Date().addingTimeInterval(5)
while loopNotRunningRequests.contains(where: { $0.content.interruptionLevel == .timeSensitive && $0.content.sound != nil }), Date() < deadline {
RunLoop.current.run(until: Date().addingTimeInterval(0.1))
loopNotRunningRequests = pendingLoopNotRunningRequests()
}

wait(for: [testExpectation], timeout: 1)
if #available(iOS 15.0, *) {
XCTAssertNil(loopNotRunningRequests.first(where: { $0.content.interruptionLevel == .timeSensitive })?.content.sound)
if let request = loopNotRunningRequests.first(where: { $0.content.interruptionLevel == .critical }) {
Expand All @@ -521,6 +523,19 @@ class AlertManagerTests: XCTestCase {
}
}
}

private func pendingLoopNotRunningRequests() -> [UNNotificationRequest] {
let pendingExpectation = expectation(description: #function)
var requests: [UNNotificationRequest] = []
UNUserNotificationCenter.current().getPendingNotificationRequests() { notificationRequests in
requests = notificationRequests.filter({
$0.content.categoryIdentifier == LoopNotificationCategory.loopNotRunning.rawValue
})
pendingExpectation.fulfill()
}
wait(for: [pendingExpectation], timeout: 1)
return requests
}
}

extension Swift.Result {
Expand Down