Repository navigation
Conversation
Remove an unused trade-id constant and redundant moves of temporary unique_ptr values. Keep ownership and callback behavior unchanged.
LimiNode
force-pushed
the
build/update-dependencies
branch
from
October 15, 2026 20:28
f9016f3 to
b28c123
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- remove the unused trade-id constant from TradeRecordDB\n- remove redundant std::move calls around temporary unique_ptr values in TradeQueueManager\n\n## Verification\n\n- checked the staged diff and whitespace\n- compiled the optionx aggregate with g++ -Wall -std=c++17 -fsyntax-only\n- remaining warnings are from external OpenSSL/curl and mdbx-containers headers\n\nThe existing unrelated working-tree changes are intentionally not included in this commit.