Repository navigation
fix(web): dynamically resolve PHP-FPM after container recreation - #90
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Recreating the PHP-FPM
appcontainer may change its Docker IP. With a statically resolved upstream, Nginx can keep connecting to the old address and return HTTP 502 until it is reloaded. This affected the Portabilis instance on Ada and can affect the LibreCode instance.Changes
127.0.0.11) and dynamic Nginx upstream resolution forapp:9000, including a shared zone and bounded DNS refresh/timeout.no-cache-filters: runtimefor the app images andno-cache: truefor the small web image. This prevents cached apt/apk upgrades from leaving fixable vulnerabilities in new builds.tests/ci/,tests/app/,tests/web/,tests/development/andtests/cli/. The Makefile selects all*.batsfiles in each category. Adding a test within an existing category requires no Makefile or workflow edits.build-and-scancomposite action, not as standalone single-file workflow steps. Adjust the master-image and NCDD workflows to run the same Makefile targets and use directory-based path filters.Validation
make test-web-imagewithout any change to the Makefile or workflows. The temporary test was removed.1d2b7b5passed the complete stable-image matrix, Trivy, and runtime tests in CI run #157. CI revalidated successfully at commit43e0a73: stable-image matrix #158 passed for Nextcloud 33/34/35, Nginx/Trivy/Bats and offline scripts; master image #64 passed for AMD64 and ARM64; NCDD CLI #60 passed. Image publication jobs were skipped as intended on pull requests. No production deployment or merge performed.Scope and rollout
resolverequires a compatible Nginx release (observed runtime: 1.31.7).webservice alias on the shared reverse-proxy network is tracked separately.