Repository navigation
Conversation
gnutls_record_send() and gnutls_record_recv() may return GNUTLS_E_AGAIN or GNUTLS_E_INTERRUPTED. Both are non-fatal, gnutls_error_is_fatal() returns 0 for them, and the call is meant to be repeated. csync2 passed the negative return straight up instead: conn_read() turned it into a short read and csync_recv_file() called csync_fatal(), while csync_send_file() saw rc != chunk and did the same. A large transfer therefore died on a condition GnuTLS reports as harmless, in practice after roughly 7.4 GiB over a single connection. Pushing 31.66 GB of mixed files to two peers took seven csync2 runs to converge; with this it takes one. Both paths need it. Patching only the sending side changed nothing, because the receive path then aborted on the identical condition. The send loop only advances the offset after a successful send, so a retry repeats the identical (pointer, length) pair, as the GnuTLS manual requires. The socket is blocking, no O_NONBLOCK is ever set on conn_fd_in/conn_fd_out, so the retry cannot spin. The non-TLS branch of WRITE() already loops over partial writes and retries EINTR; this makes the TLS branch behave the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnutls_record_send() and gnutls_record_recv() may return GNUTLS_E_AGAIN or GNUTLS_E_INTERRUPTED. Both are non-fatal, gnutls_error_is_fatal() returns 0 for them, and the call is meant to be repeated. csync2 passed the negative return straight up instead: conn_read() turned it into a short read and csync_recv_file() called csync_fatal(), while csync_send_file() saw rc != chunk and did the same.
A large transfer therefore died on a condition GnuTLS reports as harmless, in practice after roughly 7.4 GiB over a single connection. Pushing 31.66 GB of mixed files to two peers took seven csync2 runs to converge; with this it takes one.
Both paths need it. Patching only the sending side changed nothing, because the receive path then aborted on the identical condition.
The send loop only advances the offset after a successful send, so a retry repeats the identical (pointer, length) pair, as the GnuTLS manual requires. The socket is blocking, no O_NONBLOCK is ever set on conn_fd_in/conn_fd_out, so the retry cannot spin. The non-TLS branch of WRITE() already loops over partial writes and retries EINTR; this makes the TLS branch behave the same.