Improve code snipper HTTP #304

Activity

1. jaroga86 commented on Sep 23, 2022

   

   jaroga86

   on Sep 23, 2022

   Author

   More actions

   @dimitropoulos
   Please advise whether the capitalization of HTTP headers is needed at httpsnippet.
   As HTTP Headers are case sensitive, we think this transformation (toUpperCase()) should not be done. It is preventing us from using the httpsnippet with the expected result and causing header capitalization caused errors while using the http code generated by httpsnippet.
   This is the code section we don't understand, and even there is commented that it is not required. Shouldn't it be deleted, then?
   // Capitalize header keys, even though it's not required by the spec.
   const keyCapitalized = key.toLowerCase().replace(/(^|-)(\w)/g, input => input.toUpperCase());
   push(${keyCapitalized}: ${allHeaders[key]});
2. erunion commented on Oct 3, 2022

   

   erunion

   on Oct 3, 2022

   Contributor

   More actions

   Please advise whether the capitalization of HTTP headers is needed at httpsnippet.

   @jaroga86 HTTP headers are case-insensitive in HTTP/1.1:

   Each header field consists of a name followed by a colon (":") and the 
   field value. Field names are case-insensitive.
   

   However in HTTP/2 they must be lowercased:

   Just as in HTTP/1.x, header field names are strings of ASCII characters 
   that are compared in a case-insensitive fashion.  However, header field 
   names MUST be converted to lowercase prior to their encoding in HTTP/2.  
   A request or response containing uppercase header field names MUST 
   be treated as malformed.
   
3. verhovsky commented on Feb 25, 2023

   

   verhovsky

   on Feb 25, 2023

   Last edited by verhovsky

   Contributor

   More actions

   The user wants you to remove this line

   httpsnippet/src/targets/http/http1.1/client.ts

   Line 59 in cee79a5

   const keyCapitalized = key.toLowerCase().replace(/(^|-)(\w)/g, input => input.toUpperCase());

   and just keep the header as-is presumably because whatever server they're using is expecting those custom headers to be lower case.

   If you input "operation-date", it should output "operation-date", but in this case the HTTP target is needlessly capitalizing all headers, including that header name too, to Operation-Date. The curl target correctly preserves the case and outputs operation-date.