Repository navigation
fix(Manipulators): remove errors in KeyboardCameraManipulator example - #3687
Merged
finetjul merged 1 commit intoOct 19, 2026
Merged
Conversation
Member
Contributor
|
LGTM |
|
🎉 This PR is included in version 37.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
fix #3660
The KeyboardCameraManipulator example throws on click and on key release.
Results
publicAPI.startPointerLockInteraction is not a function. Mouse look works the same, it already comes fromonMouseMovereadingmovementX/movementYwhile the pointer is locked.model._interactor is undefined, and the animation request is canceled.Changes
endMovementusesmodel.interactor, which is whatonKeyDownsets.onButtonDownonly requests the pointer lock and no longer calls the missingstartPointerLockInteraction.KeyboardCameraManipulator/test/testKeyboardCameraManipulator.js(key down then key up, fails before the change).No API changes.
PR Checklist