Repository navigation
Fix shared build type model on Manage Build Groups page - #4163
Merged
josephsnyder merged 1 commit intoOct 30, 2026
Merged
Conversation
On the Manage BuildGroups page, choosing a Build Type on the Wildcard BuildGroups tab broke the Create new BuildGroup tab, so new groups failed to save with a server error. Each tab now keeps its own Build Type selection. ### To reproduce 1. As a project admin, open `manageBuildGroup.php?projectid=<id>`. 2. On the **Wildcard BuildGroups** tab, choose any Build Type. 3. Switch to **Create new BuildGroup**, enter a name, and click **Create BuildGroup**.
josephsnyder
approved these changes
Oct 30, 2026
josephsnyder
left a comment
josephsnyder
left a comment
Member
There was a problem hiding this comment.
No errors on after applying the patch.
I also created #4181 which I found during testing of this MR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Manage BuildGroups page, choosing a Build Type on the Wildcard BuildGroups tab broke the Create new BuildGroup tab, so new groups failed to save with a server error. Each tab now keeps its own Build Type selection.
To reproduce
manageBuildGroup.php?projectid=<id>.