Skip to content

fix(cli): fix disable auto-approve leaving stale config and UI - #8972

Merged
alex-alecu merged 5 commits into
mainfrom
kilocode-auto-approve-permissions
Apr 15, 2026
Merged

alex-alecu merged 5 commits into
mainfrom
kilocode-auto-approve-permissions

Conversation

@alex-alecu

@alex-alecu alex-alecu commented Apr 15, 2026 •

Copy link
Copy Markdown
Contributor

Why

Original PR #7764 broken by last OpenCode merges.

Disabling auto-approve mode from the command palette was failing silently or leaving the toggle stuck on "Disable" even after succeeding. The config file ended up with a broken empty permission entry instead of being cleaned up properly, and the UI never got notified that the config changed.

How to test

  1. Run kilo and open the command palette
  2. Select "Enable auto-approve mode" — it should toggle to "Disable auto-approve mode"
  3. Select "Disable auto-approve mode" — it should toggle back to "Enable auto-approve mode" without errors
  4. Run bun test test/server/permission-allow-everything.test.ts from packages/opencode/ — both tests should pass

@kilo-code-bot

kilo-code-bot Bot commented Apr 15, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • packages/opencode/src/kilocode/config/config.ts
  • packages/opencode/src/kilocode/permission/routes.ts
  • packages/opencode/test/kilocode/server/permission-allow-everything.test.ts

Reviewed by gpt-5.4-20260305 · 602,929 tokens

@alex-alecu
alex-alecu enabled auto-merge April 15, 2026 11:46
@alex-alecu
alex-alecu merged commit e8fd495 into main Apr 15, 2026
16 checks passed
@alex-alecu
alex-alecu deleted the kilocode-auto-approve-permissions branch April 15, 2026 13:49
slamj1 pushed a commit to slamj1/kilocode that referenced this pull request May 16, 2026
jliounis pushed a commit to jliounis/kilocode that referenced this pull request May 18, 2026
jliounis pushed a commit to jliounis/kilocode that referenced this pull request May 18, 2026
…permissions

fix(cli): fix disable auto-approve leaving stale config and UI
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
t7tran pushed a commit to t7tran/kilocode that referenced this pull request Aug 14, 2026
…permissions

fix(cli): fix disable auto-approve leaving stale config and UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants