Repository navigation
feat(vscode): enable VS Code notifications by default - #15649
Open
sylwester-liljegren wants to merge 1 commit into
Open
sylwester-liljegren wants to merge 1 commit into
sylwester-liljegren wants to merge 1 commit into
Conversation
Turn kilo-code.new.attention.notifications on by default so users see when an off-screen session completes, needs input or permission, or stops on an error. Sounds and native OS notifications stay opt-in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge lgtm — the manifest default, the Files Reviewed (7 files)
Reviewed by deepseek-flash-latest · Input: 55.1K · Output: 7.4K · Cached: 860.9K Review guidance: REVIEW.md from base branch |
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No existing issue. This is a follow-up to #13771, which added attention notifications with every channel off by default.
Context
VS Code notifications (
kilo-code.new.attention.notifications) tell users when a session completes, asks a question, needs permission, or stops on an error. Because they were opt-in, most users never find the setting. They miss the permission prompts and questions that leave an agent waiting on them. This PR turns VS Code notifications on by default.They work well as a default because they are already narrowly gated:
Implementation
The manifest default flips to
true. The code fallbacks inKiloProviderandAttentionService, and the Settings tab's state before settings load, are updated to match the manifest.Sounds and native OS notifications deliberately stay opt-in:
powershell.exe -EncodedCommand, a pattern endpoint-security tools commonly flag.osascriptattributes the notification to Script Editor.These tradeoffs are fine for a user who turns the feature on. They are not fine as a default.
Users who never changed the setting will start getting VS Code notifications after they update. Users who toggled it in Settings keep their stored value.
Screenshots / Video
N/A. There is no UI change. The existing Enable VS Code Notifications toggle in Settings > Notifications now starts in the on position for users without a stored value.
How to Test
Manual/local verification
bun run typecheckinpackages/kilo-vscode/: passes.bun run lintinpackages/kilo-vscode/: passes.bun test tests/unit/attention.test.ts tests/unit/attention-os.test.tsinpackages/kilo-vscode/: 43 pass, 0 fail. The defaults test now pinsattention.notificationstotrue, and the sound and OS notification defaults stayfalse.bun test tests/unit/) inpackages/kilo-vscode/on Windows: 6808 pass, 29 skip, 129 fail. All the failures already exist onmainon this machine. See "Blocked checks" below.bun run script/check-md-table-padding.tsfrom the repo root: passes.bunx prettier --checkon the changed files: passes.Reviewer test steps
settings.jsonhas nokilo-code.new.attention.notificationsentry, and run this build.settings.jsonnow contains"kilo-code.new.attention.notifications": false, and step 3 no longer shows a notification.Blocked checks and substitute verification
--no-verify). The hooks run the repo-widebun turbo typecheck, which includes the JetBrains plugin and needs Java 21, which is not installed on this machine. Substitute verification was the package-level typecheck, lint, and unit tests above. They coverpackages/kilo-vscode/, the only code package this PR touches. The rest of the change is a docs page and a changeset.mainand on this branch:mainhad 126 failures and the branch had 116. The set differs between runs. The one test that failed only on the branch,WorktreeManager pool claim > preserves an existing branch when a delta claim collides with the slot name, also fails onmainwhen run alone. CI on Linux is the authoritative run for these.Checklist
Get in Touch
🤖 Generated with Claude Code