Repository navigation
chore(jetbrains): bump the kotlin-minor-patch group across 1 directory with 3 updates - #15547
dependabot[bot] wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
The Files Reviewed (1 file)
Fix these issues in Kilo Cloud Previous Review Summary (commit 6cd6c6f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6cd6c6f)Status: No Issues Found | Recommendation: Merge Dependabot version bump only: Files Reviewed (1 file)
Reviewed by deepseek-flash-latest · Input: 50.2K · Output: 4.6K · Cached: 361.9K Review guidance: REVIEW.md from base branch |
…y with 3 updates Bumps the kotlin-minor-patch group with 3 updates in the /packages/kilo-jetbrains directory: [org.jetbrains.kotlinx:kotlinx-serialization-json](https://github.com/Kotlin/kotlinx.serialization), org.jetbrains.kotlin.jvm and org.jetbrains.kotlin.plugin.serialization. Updates `org.jetbrains.kotlinx:kotlinx-serialization-json` from 1.11.0 to 1.12.0 - [Release notes](https://github.com/Kotlin/kotlinx.serialization/releases) - [Changelog](https://github.com/Kotlin/kotlinx.serialization/blob/master/CHANGELOG.md) - [Commits](Kotlin/kotlinx.serialization@v1.11.0...v1.12.0) Updates `org.jetbrains.kotlin.jvm` from 2.3.20 to 2.4.21 Updates `org.jetbrains.kotlin.plugin.serialization` from 2.3.20 to 2.4.21 --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.jvm dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kotlin-minor-patch - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-version: 2.4.21 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kotlin-minor-patch - dependency-name: org.jetbrains.kotlinx:kotlinx-serialization-json dependency-version: 1.12.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kotlin-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
6cd6c6f to
22870ba
Compare
| kotlin-jvm-plugin = "2.3.20" | ||
| kotlin-serialization-plugin = "2.3.20" | ||
| kotlin-serialization = "1.11.0" | ||
| kotlin-jvm-plugin = "2.4.21" |
There was a problem hiding this comment.
CRITICAL: Bumping kotlin-jvm-plugin to 2.4.21 while intellij-rpc-plugin stays on 2.3.21-RC2-0.1 breaks the JetBrains Gradle configuration.
packages/kilo-jetbrains/build.gradle.kts:122 fails the build when the Kotlin minor and RPC plugin minor differ (minor(compiler) != minor(rpc)), which is exactly what this bump produces (2.4 vs 2.3). The comment above this block and the enforcement itself were added after the earlier 2.4.x attempts: #14755, #14950, #15157 and #15421 were all closed for this reason. Without the guard, :shared:compileKotlin fails with an opaque IrGenerationExtension$Companion cannot be cast to ProjectExtensionDescriptor error.
Suggestion: hold this bump until an intellij-rpc-plugin build targeting Kotlin 2.4.x exists, then raise kotlin-jvm-plugin, kotlin-serialization-plugin and intellij-rpc-plugin in the same change. The kotlinx-serialization-json 1.11.0 → 1.12.0 part is fine on its own.
Bumps the kotlin-minor-patch group with 3 updates in the /packages/kilo-jetbrains directory: org.jetbrains.kotlinx:kotlinx-serialization-json, org.jetbrains.kotlin.jvm and org.jetbrains.kotlin.plugin.serialization.
Updates
org.jetbrains.kotlinx:kotlinx-serialization-jsonfrom 1.11.0 to 1.12.0Release notes
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-json's releases.
... (truncated)
Changelog
Sourced from org.jetbrains.kotlinx:kotlinx-serialization-json's changelog.
... (truncated)
Commits
4c28c3e1.12.0 release (#3295)abe8a96Merge remote-tracking branch 'origin/master' into dev952d17aAdded Gradle task to prepare release (#3279)6f30025Remove Play verification files (#3266)89b23caWorkaround watchosArm32 removal (#3291)53932a0Update links to Okio site and its docs (#3292)3a5db3bReduce the number of input fields for bug report9ede0e2Added templates to the issue creation wizard5d3f884Update Dokka to version 2.3.0-Beta (#3286)1fe9a49Suppress deprecation of nodejs in wasmWasi configuration (#3287)Updates
org.jetbrains.kotlin.jvmfrom 2.3.20 to 2.4.21Updates
org.jetbrains.kotlin.plugin.serializationfrom 2.3.20 to 2.4.21