You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(vscode): fall back to session directory for permission replies - #14738
What:handlePermissionResponse now falls back to getWorkspaceDirectory(target) when no permission directory is recorded.
Why: After an SSE reconnect/prune, or for child subagent permissions, no directory was recorded. The reply hit Unknown permission route, showed "Failed to update permissions", and left the dialog stuck. question.ts already uses the same fallback.
The old test asserted no fallback; it now asserts the session-directory fallback.
The change makes handlePermissionResponse fall back to getWorkspaceDirectory(target) when no permission directory is recorded, matching the existing question.ts fallback. This correctly addresses the SSE-reconnect/prune and child-subagent cases where the reply previously hit Unknown permission route and left the dialog stuck. The backend still validates the requestID against the target directory, so an incorrect fallback degrades to the existing stale/404 path rather than mis-applying a rule. No new resource leaks (no added listeners, timers, or unbounded maps); clearPermissionDirectory is still called on every terminal path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14467
What:
handlePermissionResponsenow falls back togetWorkspaceDirectory(target)when no permission directory is recorded.Why: After an SSE reconnect/prune, or for child subagent permissions, no directory was recorded. The reply hit
Unknown permission route, showed "Failed to update permissions", and left the dialog stuck.question.tsalready uses the same fallback.The old test asserted no fallback; it now asserts the session-directory fallback.