Skip to content

fix(tui): render suggest tool actions - #14708

Merged
marius-kilocode merged 1 commit into
mainfrom
suggest-tool-rendering
Oct 1, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
suggest-tool-rendering

Conversation

@jeanduplessis

Copy link
Copy Markdown
Contributor

The suggest tool's renderer was never dispatched by the TUI. It fell through to the generic tool fallback, so users saw a raw ⚙ suggest [suggest=…] line instead of the suggestion bar, and the action buttons never appeared. The fallback only prints primitive parameters, which drops the actions array.

This connects the existing Suggest renderer in the session route and passes it the live suggestion request. The request is matched by session, message ID, and call ID, so a tool part only shows its own suggestion. The renderer itself is unchanged.

The built-in tool emits non-blocking suggestions, which the footer intentionally skips. That left the tool part as the only place these suggestions could render.

The added test guards that suggest is recognized by the dispatcher. It does not cover the route-level request matching, which would need a full session-route harness.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-01T07:49:58.577264Z c8aaebf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants