Repository navigation
fix(tui): render suggest tool actions - #14708
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
marius-kilocode
approved these changes
Oct 1, 2026
This was referenced Oct 2, 2026
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
suggesttool's renderer was never dispatched by the TUI. It fell through to the generic tool fallback, so users saw a raw⚙ suggest [suggest=…]line instead of the suggestion bar, and the action buttons never appeared. The fallback only prints primitive parameters, which drops theactionsarray.This connects the existing
Suggestrenderer in the session route and passes it the live suggestion request. The request is matched by session, message ID, and call ID, so a tool part only shows its own suggestion. The renderer itself is unchanged.The built-in tool emits non-blocking suggestions, which the footer intentionally skips. That left the tool part as the only place these suggestions could render.
The added test guards that
suggestis recognized by the dispatcher. It does not cover the route-level request matching, which would need a full session-route harness.