Skip to content

test(sbom): read okhttp version from the JetBrains catalog - #14696

Merged
brunoagatao merged 1 commit into
mainfrom
fix/sbom-test-okhttp-version
Sep 30, 2026
Merged

brunoagatao merged 1 commit into
mainfrom
fix/sbom-test-okhttp-version

Conversation

@brunoagatao

Copy link
Copy Markdown
Collaborator

Fixes the failing test workflow on main.

Two tests in script/kilocode/sbom-products.test.ts read the real packages/kilo-jetbrains/gradle/libs.versions.toml but hardcoded okhttp 4.12.0. The OkHttp 5.5.0 bump (#14559) changed the catalog only, so the JS tests were skipped on that PR and broke on main.

The tests now read the expected version from the catalog, so later Dependabot bumps do not break them. The inline-catalog test keeps its own fixture value.

Not changed: test.yml still skips the unit tests for Gradle-only changes. That filter uses an every quantifier, so an exception needs a separate output. It can be a follow-up.

@brunoagatao
brunoagatao requested a review from kirillk September 30, 2026 16:59
@kilo-code-bot

kilo-code-bot Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The change replaces the hardcoded okhttp 4.12.0 expectation with a value read from the authoritative JetBrains version catalog, which correctly tracks the OkHttp 5.5.0 bump. The regex /^okhttp\s*=\s*"([^"]+)"/m matches only the [versions] entry (the okhttp-sse/okhttp-mockwebserver keys and the { module = ... } library lines have a - or { after the key and cannot match), and the synthetic inline-catalog fixture at line 39 is intentionally left hardcoded. import.meta.dir usage matches the existing pattern at lines 63-66. No further issues found.

Files Reviewed (1 file)
  • script/kilocode/sbom-products.test.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@brunoagatao
brunoagatao merged commit e211707 into main Sep 30, 2026
32 checks passed
@brunoagatao
brunoagatao deleted the fix/sbom-test-okhttp-version branch September 30, 2026 17:07
@brunoagatao brunoagatao self-assigned this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants