Repository navigation
test(sbom): read okhttp version from the JetBrains catalog - #14696
Merged
Merged
Conversation
zfralish
approved these changes
Sep 30, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The change replaces the hardcoded Files Reviewed (1 file)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
testworkflow onmain.Two tests in
script/kilocode/sbom-products.test.tsread the realpackages/kilo-jetbrains/gradle/libs.versions.tomlbut hardcodedokhttp4.12.0. The OkHttp 5.5.0 bump (#14559) changed the catalog only, so the JS tests were skipped on that PR and broke onmain.The tests now read the expected version from the catalog, so later Dependabot bumps do not break them. The inline-catalog test keeps its own fixture value.
Not changed:
test.ymlstill skips the unit tests for Gradle-only changes. That filter uses aneveryquantifier, so an exception needs a separate output. It can be a follow-up.