Repository navigation
feat(agent-manager): add close to the right tab action - #14444
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The close-to-right logic mirrors the existing Close Others semantics correctly. I verified the changed lines in context: Files Reviewed (31 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
WebReflection
left a comment
There was a problem hiding this comment.
this looks good to me, I just wonder if some custom theme or some right to left language would have a different meaning for right but I guess we'll figure that out.
What Problem This Solves
The Agent Manager tab context menu offers Close and Close Others, but no way to close only the tabs that sit after the current one. With several session, terminal, and review tabs open, clearing the trailing tabs means closing them one at a time.
Why This Change Was Made
Add Close to the Right directly after Close Others in the Agent Manager tab context menu. It closes the session, terminal, and review tabs after the target in the current left-to-right order.
Behavior details:
close-to-right.ts) next to the existingclose-others.ts, andcloseOtherskeeps its existing behavior through a small sharedrevealhelper.Closes #14433
User Impact
Right-click a tab in the Agent Manager tab bar and choose Close to the Right. The tabs after it close, and the current selection is preserved unless it was one of the closed tabs.
After choosing it, only the tabs at or before the target remain:
Evidence
Manual verification in an isolated VS Code dev instance with the rebuilt webview:
Automated checks:
bun test tests/unit/close-to-right.test.ts tests/unit/close-others.test.ts-> 26 pass.agentManager.tab.closeToRightkey added to all 21 agent-manager locales.bun run lintandbun run knippass.bun run check-types:webviewreports only pre-existing errors from missing generated SDK members and unbuilt workspace packages. No errors come from the touched files.