Repository navigation
fix(jetbrains): wrap session status messages - #14435
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The two previous findings are resolved in Files Reviewed (3 files)
Previous Review Summary (commit 4dd6905)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 4dd6905)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
- Read the ancestor's fresh width in Footer.space() instead of this component's stale width, matching SessionLayout's resize-then-measure pattern. - Extract the escaped-lines HTML builder into UiStyle.Text.wrapLines() so it shares implementation with tipLines() instead of duplicating it.
zfralish
approved these changes
Sep 22, 2026
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No linked issue. This fixes the directly reported JetBrains session bug where long provider retry messages are clipped instead of wrapping.
Context
Long retry and offline status messages can exceed the session width, especially for provider-capacity errors. The existing footer lays out the status at its natural single-line width, so text is clipped beside the spinner and elapsed timer.
Implementation
Render retry and offline messages as escaped HTML in retained, copyable
JBLabelcomponents with auto-wrapping enabled. A width-aware footer layout reserves space for the spinner and elapsed timer before measuring the message, while keeping short rows centered. Busy text remains on the existing plainShimmerLabelso its animation and styling are unchanged. The pre-transcript loading state uses the same HTML wrapping behavior.Provider text remains semantic plain text for accessibility and assertions, HTML-looking content is escaped, and explicit line breaks are preserved.
Screenshots / Video
N/A: an after screenshot was not captured in the headless test environment. The originating report included the clipped before state; automated Swing geometry tests verify increased multi-line height and bounded child layout at narrow widths.
How to Test
Manual/local verification
./gradlew typecheck testfrompackages/kilo-jetbrains/; all JetBrains typechecks and tests passed.ProgressPanelTest,LoadingPanelTest, andSessionUiLayoutTestsuites; all passed.Reviewer test steps
Blocked checks and substitute verification
Checklist
Get in Touch
Not provided.