Skip to content

fix(vscode): inline esbuild watch problem matcher and drop extension dependency - #14254

Merged
brunoagatao merged 3 commits into
mainfrom
fix/vscode-inline-esbuild-problem-matcher
Oct 13, 2026
Merged

brunoagatao merged 3 commits into
mainfrom
fix/vscode-inline-esbuild-problem-matcher

Conversation

@brunoagatao

Copy link
Copy Markdown
Collaborator

Issue

No linked issue. Found while investigating a $esbuild-watch problem matcher error surfaced in Cursor's Output panel.

Context

The VSCode - ESBuild task in .vscode/tasks.json referenced the $esbuild-watch problem matcher, which is contributed by the connor4312.esbuild-problem-matchers extension. That extension is published only on the Microsoft Marketplace and is unavailable on Open VSX, so it cannot be installed in Open VSX-based editors (e.g. Cursor). This produced Error: Invalid problemMatcher reference: $esbuild-watch and left ESBuild watch errors unparsed in those editors.

Implementation

Replaced the $esbuild-watch reference with an inline problem matcher definition in .vscode/tasks.json. The matcher parses the same [watch] build started / [watch] build finished markers and ✘ [ERROR] ... lines already emitted by esbuildProblemMatcherPlugin in packages/kilo-vscode/esbuild.js, so behavior for existing VS Code users is unchanged and no extension is required by anyone going forward.

Since the extension is no longer needed, also removed it from .vscode/extensions.json recommendations and cleaned up its now-stale references in packages/kilo-docs/pages/contributing/development-environment.md and the link-check allowlist in packages/kilo-docs/lychee.toml.

Screenshots / Video

N/A — config/task and docs changes only, no UI change.

How to Test

Manual/local verification

  • (Agent) Validated .vscode/tasks.json remains valid JSONC after the edit.
  • (Agent) Cross-checked the inline matcher's regex and background begin/end patterns against the actual console.log/console.error output in packages/kilo-vscode/esbuild.js ([watch] build started, ✘ [ERROR] ..., [watch] build finished) to confirm they match.
  • (Agent) Confirmed no remaining references to connor4312/esbuild-problem-matchers anywhere in the repo after removing them from extensions.json, the contributing doc, and lychee.toml.

Reviewer test steps

  1. Open the repo in Cursor (or another Open VSX-based editor) without connor4312.esbuild-problem-matchers installed.
  2. Run the VSCode - ESBuild task (or VSCode - Watch, which depends on it).
  3. Confirm no Invalid problemMatcher reference error appears in the Output panel.
  4. Introduce a temporary syntax error in extension source, confirm it surfaces in the Problems tab while the watch task is running, then revert the error.

@brunoagatao brunoagatao self-assigned this Sep 17, 2026
Comment thread .vscode/tasks.json Resolved
@kilo-code-bot

kilo-code-bot Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The previously flagged .vscode/tasks.json matcher gap is resolved: the inline matcher now captures file/line/column via a second pattern with a fileLocation base matching the esbuild task cwd (packages/kilo-vscode), and the pattern order matches the plugin output in packages/kilo-vscode/esbuild.js (✘ [ERROR] <text> followed by <file>:<line>:<column>:).

Files Reviewed (4 files)
  • .vscode/extensions.json
  • .vscode/tasks.json
  • packages/kilo-docs/lychee.toml
  • packages/kilo-docs/pages/contributing/development-environment.md
Previous Review Summary (commit 44b0608)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 44b0608)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
.vscode/tasks.json 29 The inline matcher captures only the error message, not the file:line:column location the watch plugin already prints, so errors appear without a source location.
Files Reviewed (4 files)
  • .vscode/extensions.json - no issues
  • .vscode/tasks.json - 1 suggestion
  • packages/kilo-docs/lychee.toml - no issues
  • packages/kilo-docs/pages/contributing/development-environment.md - no issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@brunoagatao
brunoagatao merged commit 433fb11 into main Oct 13, 2026
34 checks passed
@brunoagatao
brunoagatao deleted the fix/vscode-inline-esbuild-problem-matcher branch October 13, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants