Repository navigation
fix(vscode): inline esbuild watch problem matcher and drop extension dependency - #14254
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previously flagged Files Reviewed (4 files)
Previous Review Summary (commit 44b0608)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 44b0608)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
WebReflection
approved these changes
Oct 7, 2026
This was referenced Oct 14, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No linked issue. Found while investigating a
$esbuild-watchproblem matcher error surfaced in Cursor's Output panel.Context
The
VSCode - ESBuildtask in.vscode/tasks.jsonreferenced the$esbuild-watchproblem matcher, which is contributed by theconnor4312.esbuild-problem-matchersextension. That extension is published only on the Microsoft Marketplace and is unavailable on Open VSX, so it cannot be installed in Open VSX-based editors (e.g. Cursor). This producedError: Invalid problemMatcher reference: $esbuild-watchand left ESBuild watch errors unparsed in those editors.Implementation
Replaced the
$esbuild-watchreference with an inline problem matcher definition in.vscode/tasks.json. The matcher parses the same[watch] build started/[watch] build finishedmarkers and✘ [ERROR] ...lines already emitted byesbuildProblemMatcherPlugininpackages/kilo-vscode/esbuild.js, so behavior for existing VS Code users is unchanged and no extension is required by anyone going forward.Since the extension is no longer needed, also removed it from
.vscode/extensions.jsonrecommendations and cleaned up its now-stale references inpackages/kilo-docs/pages/contributing/development-environment.mdand the link-check allowlist inpackages/kilo-docs/lychee.toml.Screenshots / Video
N/A — config/task and docs changes only, no UI change.
How to Test
Manual/local verification
.vscode/tasks.jsonremains valid JSONC after the edit.console.log/console.erroroutput inpackages/kilo-vscode/esbuild.js([watch] build started,✘ [ERROR] ...,[watch] build finished) to confirm they match.connor4312/esbuild-problem-matchersanywhere in the repo after removing them fromextensions.json, the contributing doc, andlychee.toml.Reviewer test steps
connor4312.esbuild-problem-matchersinstalled.VSCode - ESBuildtask (orVSCode - Watch, which depends on it).Invalid problemMatcher referenceerror appears in the Output panel.