Repository navigation
chore(agent-manager): remove dead member methods - #14244
Merged
Merged
Conversation
Delete unused WorktreeManager.hasOriginRemote, WorktreeStateManager.removeTabOrder, GitOps.hasRemoteRef, SetupScriptService.log, and the AgentManagerProvider worktrees and setupScript getters, along with their unit tests. All members had no production callers.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Verified each removed member has no remaining callers ( Files Reviewed (8 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 17, 2026 13:04
WebReflection
approved these changes
Sep 17, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removes Agent Manager members that have no production callers:
WorktreeManager.hasOriginRemoteWorktreeStateManager.removeTabOrderGitOps.hasRemoteRefSetupScriptService.logAgentManagerProvidergettersworktreesandsetupScriptEach member's unit test is removed with it. No new helpers, abstractions, or tests are added.
Why
These members are unreferenced dead code. Verified with
rg -n '<symbol>' src webview-ui tests: the only hits were each definition plus the test being removed.this.worktreesmatches only theWorktreeStateManagerfield (a different class) andthis.setupScripthas zero references.Evidence
bun run lint: pass.bun test tests/unit/worktree-manager.test.ts tests/unit/worktree-state-manager.test.ts tests/unit/git-ops.test.ts tests/unit/agent-manager-arch.test.ts: 318 pass, 1 skip, 0 fail.bun run typecheck: fails only on pre-existing, unrelated SDK generated-type errors (@kilocode/sdk/v2/clientmissing exports,Config.sandbox,Kilocode.marketplace); none are in the touched files.