Skip to content

chore(agent-manager): remove dead member methods - #14244

Merged
marius-kilocode merged 1 commit into
mainfrom
chore/remove-dead-agent-manager-members
Sep 17, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
chore/remove-dead-agent-manager-members

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What changed

Removes Agent Manager members that have no production callers:

  • WorktreeManager.hasOriginRemote
  • WorktreeStateManager.removeTabOrder
  • GitOps.hasRemoteRef
  • SetupScriptService.log
  • AgentManagerProvider getters worktrees and setupScript

Each member's unit test is removed with it. No new helpers, abstractions, or tests are added.

Why

These members are unreferenced dead code. Verified with rg -n '<symbol>' src webview-ui tests: the only hits were each definition plus the test being removed. this.worktrees matches only the WorktreeStateManager field (a different class) and this.setupScript has zero references.

Evidence

  • Diff is net negative: 8 files changed, 66 deletions, 0 insertions.
  • bun run lint: pass.
  • bun test tests/unit/worktree-manager.test.ts tests/unit/worktree-state-manager.test.ts tests/unit/git-ops.test.ts tests/unit/agent-manager-arch.test.ts: 318 pass, 1 skip, 0 fail.
  • bun run typecheck: fails only on pre-existing, unrelated SDK generated-type errors (@kilocode/sdk/v2/client missing exports, Config.sandbox, Kilocode.marketplace); none are in the touched files.

Delete unused WorktreeManager.hasOriginRemote, WorktreeStateManager.removeTabOrder, GitOps.hasRemoteRef, SetupScriptService.log, and the AgentManagerProvider worktrees and setupScript getters, along with their unit tests. All members had no production callers.
@kilo-code-bot

kilo-code-bot Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Verified each removed member has no remaining callers (hasOriginRemote, removeTabOrder, hasRemoteRef, SetupScriptService.log, and the worktrees/setupScript getters). The imports for WorktreeManager and SetupScriptService in AgentManagerProvider remain used by other type annotations, and peekWorktrees/peekSetup still have callers in project/wiring.ts and project/settings.ts. Deletion-only change; no user-facing behavior, so no changeset is needed.

Files Reviewed (8 files)
  • packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts
  • packages/kilo-vscode/src/agent-manager/GitOps.ts
  • packages/kilo-vscode/src/agent-manager/SetupScriptService.ts
  • packages/kilo-vscode/src/agent-manager/WorktreeManager.ts
  • packages/kilo-vscode/src/agent-manager/WorktreeStateManager.ts
  • packages/kilo-vscode/tests/unit/git-ops.test.ts
  • packages/kilo-vscode/tests/unit/worktree-manager.test.ts
  • packages/kilo-vscode/tests/unit/worktree-state-manager.test.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 8dddfab into main Sep 17, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the chore/remove-dead-agent-manager-members branch September 17, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants