Repository navigation
chore(ui): remove dead mermaid chevron styles - #14243
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
lgtm — verified the deleted Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 17, 2026 12:57
WebReflection
approved these changes
Sep 17, 2026
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The Mermaid action menu stylesheet contained three rules for
[data-slot="markdown-mermaid-menu-chevron"], including a[data-expanded]rule. The Mermaid actions component rendersdata-slot="markdown-mermaid-chevron"without themenu-prefix, so no element ever matched these rules. The styles were dead.Why This Change Was Made
Removes the unreachable rules so the stylesheet matches the rendered markup. No replacement rules are needed because the deleted selectors never applied. The change is limited to the dead block; no other rule was reformatted, reordered, or added.
Evidence
rg -n 'markdown-mermaid-menu-chevron' .before the change returned only the three deleted CSS rules.rg -n 'markdown-mermaid-chevron' packages/ui/src/kilocode/mermaidreturns the real slot atmarkdown-mermaid-actions.tsx:20.Shared / Markdown - Mermaid diagramStorybook story: the diagram,Zoom/Copy/Downloadcontrols, and the zoom overlay (header, footer,100%) all render with no console errors. The live DOM contains zeromarkdown-mermaid-menu-chevronelements.bun run --cwd packages/kilo-vscode typecheckandbun run --cwd packages/kilo-vscode lintpass.