Skip to content

chore(ui): remove dead mermaid chevron styles - #14243

Merged
marius-kilocode merged 1 commit into
mainfrom
chore/remove-dead-mermaid-chevron-css
Sep 17, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
chore/remove-dead-mermaid-chevron-css

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The Mermaid action menu stylesheet contained three rules for [data-slot="markdown-mermaid-menu-chevron"], including a [data-expanded] rule. The Mermaid actions component renders data-slot="markdown-mermaid-chevron" without the menu- prefix, so no element ever matched these rules. The styles were dead.

Why This Change Was Made

Removes the unreachable rules so the stylesheet matches the rendered markup. No replacement rules are needed because the deleted selectors never applied. The change is limited to the dead block; no other rule was reformatted, reordered, or added.

Evidence

  • rg -n 'markdown-mermaid-menu-chevron' . before the change returned only the three deleted CSS rules.
  • rg -n 'markdown-mermaid-chevron' packages/ui/src/kilocode/mermaid returns the real slot at markdown-mermaid-actions.tsx:20.
  • Diff is net negative: 1 file changed, 22 deletions.
  • Rendered the Shared / Markdown - Mermaid diagram Storybook story: the diagram, Zoom/Copy/Download controls, and the zoom overlay (header, footer, 100%) all render with no console errors. The live DOM contains zero markdown-mermaid-menu-chevron elements.
  • bun run --cwd packages/kilo-vscode typecheck and bun run --cwd packages/kilo-vscode lint pass.

@kilo-code-bot

kilo-code-bot Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • packages/ui/src/kilocode/mermaid/markdown-mermaid.css

lgtm — verified the deleted [data-slot="markdown-mermaid-menu-chevron"] rules were unreachable. The rendered slot is markdown-mermaid-chevron (markdown-mermaid-actions.tsx:20), and no markdown-mermaid-menu-chevron reference remains in the tree, so the deletion is behavior-neutral.


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 3eab5af into main Sep 17, 2026
32 checks passed
@marius-kilocode
marius-kilocode deleted the chore/remove-dead-mermaid-chevron-css branch September 17, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants