Skip to content

feat(agent-manager): move add project to a fixed footer - #14149

Merged
marius-kilocode merged 2 commits into
mainfrom
agent-manager/add-project-footer
Sep 15, 2026
Merged

marius-kilocode merged 2 commits into
mainfrom
agent-manager/add-project-footer

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 15, 2026 •

Copy link
Copy Markdown
Collaborator

What Problem This Solves

In multi-project mode the Agent Manager renders the Add project plus in the PROJECTS section header, next to the search, caffeination, and keyboard shortcuts controls. It sits beside the New worktree plus, so users confuse the two actions.

Why This Change Was Made

Adding a project is a less frequent, project-scoped action, while the header is reserved for view controls. A fixed footer below the project list separates the two plus buttons and keeps the action reachable while the list scrolls.

User Impact

  • The PROJECTS header keeps only its view controls.
  • A full-width Add project button sits in a fixed footer below the scrolling project list, so it stays visible as more projects are added.
  • The footer stays outside the scroll area in the collapsed and 200px minimum-width layouts.

Evidence

  • From packages/kilo-vscode/: typecheck, lint, knip, check-kilocode-change, and the Agent Manager arch test (76 pass).
  • Verified in an isolated VS Code instance with multiProject enabled and a fixture list long enough to scroll: the footer stays fixed, is keyboard focusable with an aria-label, and the header plus is gone.

Agent Manager project list with a full-width Add project footer pinned below the scrolling list

@kilo-code-bot

kilo-code-bot Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-200-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-scrolled-chromium-linux.png
Previous Review Summaries (3 snapshots, latest commit 60628ee)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 60628ee)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-scrolled-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/multi-project-sidebar-200-chromium-linux.png

Previous review (commit f0564ba)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css 398 Unused .am-project-actions rule added by this PR; no element uses that class
Files Reviewed (27 files)
  • .changeset/agent-manager-add-project-footer.md
  • packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectsFooter.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/ (21 locale files)
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/ (3 baseline PNGs)

The footer extraction itself is correct: ProjectsFooter renders a kilo-ui Button whose data-full-width, [data-component="button"], icon folder-add-left, and --kilo-font-size-12 tokens all resolve, the flex changes (am-projects-list { flex: 1 1 auto } plus flex-shrink: 0 on the footer) keep the footer pinned while the list scrolls, all 21 locales carry the new ... label, and the story now renders inside the real .am-sidebar column.

Fix these issues in Kilo Cloud

Previous review (commit 82357eb)

Status: No Issues Found | Recommendation: Merge

The Add project control moved cleanly from the PROJECTS header into a new pinned ProjectsFooter, with a changeset, arch-test registration, i18n updates across all 21 locales, and a reworked story that now exercises the real .am-sidebar flex column. I verified the flex changes (.am-projects-list { flex: 1 1 auto } plus flex-shrink: 0 on the footer container) resolve as intended: project rows and .am-project-body keep flex: 0 1 auto, so the extra space is absorbed by the list rather than stretching rows, and the footer's negative margins land on the existing 4px row gutter. I also confirmed data-full-width, [data-component="button"]/[data-component="icon"] selectors, the folder-add-left icon name, and the --kilo-font-size-12 token all exist and are valid, and that agentManager.project.add has no other consumer, so the trailing ellipsis only affects the new footer button.

Files Reviewed (27 files)
  • .changeset/agent-manager-add-project-footer.md
  • packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectsFooter.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/ProjectsSection.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/ (all 21 locale files)

Reviewed by deepseek-v4.1-flash · Input: 35.5K · Output: 6.1K · Cached: 298.8K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode force-pushed the agent-manager/add-project-footer branch 2 times, most recently from d2b9d2b to 2333edf Compare September 15, 2026 08:31
@marius-kilocode
marius-kilocode force-pushed the agent-manager/add-project-footer branch from f0564ba to 60628ee Compare September 15, 2026 08:47
@marius-kilocode
marius-kilocode merged commit 2272b06 into main Sep 15, 2026
27 checks passed
@marius-kilocode
marius-kilocode deleted the agent-manager/add-project-footer branch September 15, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants