Repository navigation
fix(goal): allow goals to replace running responses - #13942
Merged
Merged
Conversation
marius-kilocode
enabled auto-merge
September 9, 2026 07:42
WebReflection
approved these changes
Sep 9, 2026
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Starting a Goal while an ordinary response is running returned a Bad Request because Goal admission rejected the busy session before the replacement path could cancel it.
Why This Change Was Made
Goal submission is an explicit replacement action from the composer. The runner now validates the request and attachments first, cancels the in-flight response, then performs the existing idle admission checks before starting the Goal. Archived and reverted sessions, pending blockers, and invalid requests remain rejected.
User Impact
Users can submit a Goal while the agent is working. The current response is interrupted and the validated Goal starts instead of showing a Bad Request error.
Evidence
bun test test/kilocode/session/goal.test.ts -t ordinarybun run typecheck