Skip to content

fix(agent-manager): use consistent toolbar icon actions - #13791

Merged
marius-kilocode merged 2 commits into
mainfrom
replace-action-buttons-with-icons
Sep 4, 2026
Merged

marius-kilocode merged 2 commits into
mainfrom
replace-action-buttons-with-icons

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 4, 2026 •

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Open, Apply, and Run used text buttons beside compact icon controls in Agent Manager. The mixed widths made the action row uneven, and delayed tooltips slowed discovery of icon actions.

Why This Change Was Made

Use the existing icon-button component and shared spacing rather than a separate toolbar style. Keep descriptive tooltips, accessible button names, Run shortcuts, and the existing action handlers. Set the toolbar action tooltip delay to zero, including both dropdown arrows.

User Impact

Open, Apply, and Run now match neighboring icon actions. Apply retains its disabled conditions and centered loading indicator. Run still switches to Stop while active, and its configuration menu remains available. Tooltips appear immediately on hover.

Evidence

  • Extension build, host/webview typecheck, and lint pass.
  • Full extension unit suite: 4,840 passed, 1 skipped, 0 failed.
  • Knip, i18n usage, toolbar architecture, and Kilo change-marker checks pass.
  • Inspected the icon layout at 1x and 2x in light, dark, and both high-contrast themes.
  • Verified Run and terminal dropdown interactions in isolated VS Code.

The screenshots render the real toolbar before (86c1928c4a) and after (294219be7d) with identical sample worktree state, the Dark Modern theme, and a 1000px viewport at 2x scale. These are controlled component captures, not live backend sessions.

Before

Before: Open, Apply, and Run text buttons beside toolbar icons

After

After: Open, Apply, and Run use consistent icon buttons

Immediate hover tooltip

Apply icon showing its descriptive hover tooltip

@kilo-code-bot

kilo-code-bot Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • .changeset/quiet-toolbar-icons.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/tab-bar-full-context-chromium-linux.png
  • packages/kilo-vscode/webview-ui/agent-manager/TabBar.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/agent-manager/terminal/TerminalDestinationButton.tsx
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx

Reviewed by grok-4.6 · Input: 94.4K · Output: 14K · Cached: 940.4K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 3987c9e into main Sep 4, 2026
27 checks passed
@marius-kilocode
marius-kilocode deleted the replace-action-buttons-with-icons branch September 4, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants