Skip to content

fix(agent-manager): restore worktree delete actions - #13777

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-missing-worktree-delete-button
Sep 4, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
fix-missing-worktree-delete-button

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Agent Manager can miss a Cmd or Ctrl key-release event and leave the worktree shortcut overlay active. Every worktree then keeps its numbered shortcut badge visible, while the same overlay CSS hides every delete action. The stale state belongs to one webview instance, so another project or window can continue to work normally.

Why This Change Was Made

Modifier tracking now synchronizes from later keyboard and pointer events instead of depending only on the original modifier keyup. Moving the pointer toward a worktree repairs a lost release before hover actions are shown. Blur cleanup and normal held-modifier behavior remain unchanged.

User Impact

Worktree delete actions return automatically after a lost Cmd or Ctrl release. Shortcut badges still appear while the modifier is genuinely held.

Evidence

Before the change, a lost Cmd keyup left am-show-shortcuts enabled and the hovered close action at display: none. In the same isolated Agent Manager flow after the change, pointer movement cleared the stale mode and restored the close action with visible styling.

bun run compile, bun run test:unit (4,771 passed, 1 skipped), bun run knip, bun run check-kilocode-change, and the focused modifier tests pass.

@kilo-code-bot

kilo-code-bot Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/fix-agent-manager-shortcut-state.md
  • packages/kilo-vscode/tests/unit/agent-manager-modifier.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/modifier.ts

Reviewed by grok-4.6 · Input: 122.6K · Output: 10.7K · Cached: 191.5K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 88a3ba6 into main Sep 4, 2026
25 checks passed
@marius-kilocode
marius-kilocode deleted the fix-missing-worktree-delete-button branch September 4, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants